mirror/Arsse
1
1
Fork 0
mirror of https://code.mensbeam.com/MensBeam/Arsse.git synced 2024-12-23 17:12:41 +00:00
Code Issues Activity
1410 commits 11 branches 28 tags 4.1 MiB
Commit graph

802 commits

Author SHA1 Message Date
J. King
afbf3be031 Use 'union all' instead of 'union' in queries 2020-09-22 11:34:52 -04:00
J. King
9bc1373998 Version bump 2020-09-09 18:24:42 -04:00
J. King
0f3ada598e Work around Picofeed bug 
A fix is pending merging upstream
 2020-09-09 14:52:35 -04:00
J. King
e60f7ea03f Add class constant visibility 2020-03-01 18:32:01 -05:00
J. King
bc53a2d24a Style fixes 2020-03-01 15:16:50 -05:00
J. King
9696d55b31 Prepare ugfix release 2020-02-16 17:43:46 -05:00
J. King
39a1895867 Refine and cover new Guzzle error handling 2020-02-03 16:54:45 -05:00
J. King
06d3af0ac3 Fix remaining Picofeed-related test failures 2020-01-24 15:54:08 -05:00
J. King
49d003082d Fix problems with nicolus/picofeed 
This involved multiple fixes to Picofeed itself, not all of which have
been merged upstream yet
 2020-01-23 17:07:20 -05:00
J. King
e583ffea67 Start on integrating well-maintained picofeed fork 
Picofeed configuration does not seem to get passed to Guzzle.
 2020-01-21 08:42:38 -05:00
J. King
b5f118e8cb Cleanup 2020-01-20 13:52:48 -05:00
J. King
bbace7a0ac Use void and nullable return types where practical 2020-01-20 13:34:03 -05:00
J. King
5838af892f Replace references to Zend with Laminas 2020-01-20 10:40:05 -05:00
J. King
c4ee7254cd Refactor some tests to use data providers 2020-01-08 12:02:43 -05:00
J. King
fb2602fe04 Don't load actual configuration during CLI tests 2019-12-27 09:00:22 -05:00
J. King
3ee89bf669 Version bump 2019-12-06 17:46:53 -05:00
J. King
c9d4540616 Merge branch 'mysql' 2019-12-06 17:44:29 -05:00
J. King
bbe70b6abc Corect CamelCase references to Nextcloud 2019-12-05 13:02:02 -05:00
J. King
5df89009e6 Merge branch 'master' of https://code.mensbeam.com/MensBeam/arsse 2019-12-02 19:09:16 -05:00
J. King
15de8c2320 Fix PostgreSQL connection error message 2019-12-02 17:14:03 -05:00
J. King
737dd9f6b8 Fix foreign keys in MySQL 2019-12-01 15:00:28 -05:00
J. King
0e5b242c67 Version bump 2019-10-28 11:07:04 -04:00
J. King
c59cdfef76 Whitespace fixes 2019-10-25 15:16:35 -04:00
J. King
71c7cd8fb1 Full coverage! Fixes #66 2019-10-19 18:51:01 -04:00
J. King
728eecfbb5 Additional service tests 2019-10-19 12:14:13 -04:00
J. King
7ac4fb4715 Clarify PDO workaround for SQLite 2019-10-18 16:09:01 -04:00
J. King
3ef1177f06 Remove driver lists 2019-10-18 13:20:28 -04:00
J. King
b6dd8ab20d Improvements to and proper tests for query builder 2019-10-18 13:11:03 -04:00
J. King
c706a76057 Simplify array flattening 2019-10-18 13:10:03 -04:00
J. King
64c3ec3571 Coverage fixes and OPML bugfix 2019-10-17 13:00:56 -04:00
J. King
1809fb254e Deal with trailing whitespace in media types 2019-09-27 22:54:33 -04:00
J. King
4f5a8e3180 Make media type checking more robust 2019-09-27 22:38:03 -04:00
J. King
5f993187ea Be explicit with HTTP challenge character encoding 2019-09-27 17:16:34 -04:00
J. King
c5337b37b4 Consolidate creation of synthetic server requests 2019-09-25 18:30:53 -04:00
J. King
3da884dfbc Don't embed ito SQL strings with question marks 
Fixes #175
 2019-09-12 09:53:43 -04:00
J. King
be5ad50f54 Tests for text search clause generator 2019-09-12 09:41:01 -04:00
J. King
fb6e2babb9 Change some conditions to asserts 2019-09-12 08:32:40 -04:00
J. King
3aac583c00 Add Microsub to possible future APIs 2019-09-05 14:02:06 -04:00
J. King
c9e86e71c4 More style fixes 2019-09-05 11:25:50 -04:00
J. King
53aa7a4d0d Style fixes 2019-09-05 10:21:36 -04:00
J. King
d9c769d40e Remove Target class 2019-09-05 10:19:05 -04:00
J. King
29667464a1 Remove unnecessary namespace imports 2019-09-05 10:03:32 -04:00
J. King
0eb0fbcc0d Also normalize relative URLs 2019-09-03 19:34:56 -04:00
J. King
3439895779 Normalize URLs before establishing feed uniqueness 2019-09-03 19:04:23 -04:00
J. King
a175561574 Documentation corrections 2019-09-03 13:26:00 -04:00
J. King
bd71ddb929 Percent-encoding and IPv6 normalization 2019-09-03 13:16:05 -04:00
J. King
12fe786a2f Cleanup 2019-08-29 12:28:23 -04:00
J. King
d4802bcdb6 Handle IDNs 
While IPv6 address normalization was originally planned, this was deemed
too much effort to bother with such a niche feature; IPv6 addresses are
instead passed through unmodified
 2019-08-27 15:18:02 -04:00
J. King
dc750acf07 Handle ports, paths, and credentials correctly 2019-08-27 11:08:13 -04:00
J. King
13c27c2536 Start on URL normalizer 2019-08-26 22:13:30 -04:00
J. King
e5696fdf44 Merge branch 'manual' 2019-08-25 13:21:44 -04:00
J. King
cfef75ccba Don't update the feed URL when fetching 
This can result in some unpredictable constraint violations
 2019-08-06 09:58:30 -04:00
J. King
1ef669a464 Documentation for user management and OPML 2019-07-31 14:57:43 -04:00
J. King
eb120b4629 Fetch in three hours if caching is via etag 2019-07-27 11:03:17 -04:00
J. King
137be8bde2 Fix whitespace 2019-07-26 23:24:29 -04:00
J. King
45a43488ee Increase compatibility with misbehaving Fever clients 2019-07-26 23:23:22 -04:00
J. King
db5bcb78a3 Fix lookup of evergreen tokens 2019-07-26 20:06:47 -04:00
J. King
d6220c1bbb Merge branch 'master' into manual 2019-07-26 11:27:14 -04:00
J. King
4282ba1c26 Version bump 2019-07-26 09:39:46 -04:00
J. King
f7240301e4 Basic database maintenance 
Closes #169
 2019-07-26 09:37:51 -04:00
J. King
422eaf9605 Invalidate sessions on password change; closes #170 2019-07-25 22:34:58 -04:00
J. King
faf524c54f CLI test for import 
Fixes #35
 2019-07-25 15:45:18 -04:00
J. King
0e95892aea Do not necessarily ignore blank tags in import 
We still make them practically impossible in OPML imports, however
 2019-07-24 14:20:17 -04:00
J. King
2aa16f3405 Merge branch 'fever' into opml 2019-07-24 14:04:04 -04:00
J. King
61b942df70 Defer Fever favicons to a future release 2019-07-24 12:27:50 -04:00
J. King
0480465e7e Test Fever XML responses 
Fixes #158
 2019-07-24 09:10:13 -04:00
J. King
30cede9ea4 Make OPML parser protected 2019-07-05 14:58:05 -04:00
J. King
7046ce163c More format-neutral code out of OPML class 2019-06-21 13:47:34 -04:00
J. King
92b1626dba Remove most unused features of the query builder 
Experience has proved programmatically setting joins is not useful, and
getting the types and values of query parts was not being maintained.

The programmatic setting of GROUP BY may be useful in future, however.
 2019-06-21 12:00:23 -04:00
J. King
c1e13e6199 Tests for file imports 2019-05-12 16:33:19 -04:00
J. King
0f7d49c21e More OPML tests and fixes 2019-05-06 19:36:39 -04:00
J. King
644750487c Command line documentation and fixes 2019-05-06 00:02:59 -04:00
J. King
a30114807f Tests and fixed for OPML feed parsing 2019-05-05 20:29:44 -04:00
J. King
cdd9f4dfbe More OPML parser tests 2019-05-02 21:54:49 -04:00
J. King
5ba009cfed First set of OPML parser tests 2019-05-02 12:52:52 -04:00
J. King
6ef13d0880 Style fixes 2019-05-01 22:52:20 -04:00
J. King
b9821d925a CLI for OPML import, and proper exceptions 2019-05-01 10:46:44 -04:00
J. King
67492cd7ef Prototype OPML importer routine 
In theory the import (as opposed to parse) routine could be used for any
format; this could be used to implement an ad hoc JSON format to avoid
the loss of commas in tags with OPML
 2019-04-27 19:50:03 -04:00
J. King
3899ee6b4e Allow for replacing label and tag associations 
This supplements adding and removing
 2019-04-27 18:32:15 -04:00
J. King
2af223753d Function to add a feed without a subscription 2019-04-21 14:07:36 -04:00
J. King
ceecd58393 OPML parsing comments and minr fixes 2019-04-21 13:10:47 -04:00
J. King
825c286e5b Prototype OPML import parser 2019-04-19 18:01:31 -04:00
J. King
2d18be959c Tests for undoing read marks 2019-04-10 18:27:57 -04:00
J. King
c55a960b85 Slight cleanup 2019-04-10 15:14:45 -04:00
J. King
8532c581a8 Handle OPTIONS requests in Fever 2019-04-10 10:51:02 -04:00
J. King
afb95e53b0 Initial implementation of read-undo 2019-04-10 10:21:14 -04:00
J. King
52bc5fbda6 Tests for simple marking 2019-04-10 09:48:28 -04:00
J. King
15915a4393 Initial implementation of simple marks 2019-04-08 23:31:22 -04:00
J. King
c783ec4357 Prototype XML output for Fever 2019-04-08 20:58:45 -04:00
J. King
98fc3f4940 Test for hot links 2019-04-08 19:21:21 -04:00
J. King
4ce371ece6 Tests and fixes for Fever item listing 2019-04-08 18:41:56 -04:00
J. King
e3d2215920 Style fixes 2019-04-05 11:03:15 -04:00
J. King
0ef606aa03 Return string list of item IDs 2019-04-05 08:20:05 -04:00
J. King
0752e9cf3d Implement Fever sync 2019-04-04 19:37:48 -04:00
J. King
c6d241e653 Implement Fever item list 2019-04-04 17:57:12 -04:00
J. King
12f23ddc16 Updated tests for arbitrary sorting 2019-04-04 17:21:23 -04:00
J. King
f72c85c9f6 Hopefully working but maybe broken custom sorting 2019-04-04 11:22:50 -04:00
J. King
4b133bddd6 Prototype arbitrary result ordering 2019-04-03 15:02:59 -04:00
J. King
74fc39fca0 Implement multi-folder context option 2019-04-02 22:44:09 -04:00
J. King
cce1089e10 Handle edge case with folder 0 
Folder 0 (the root folder) is a valid, though nonsensical selection:
using it as a positive option is the same as not using the option at
all, and using it as a negative option necessarily yields an empty set.

However, it can in some contexts be validly specified, and so it should
be handled consistently. It had not been previously, but is now.
 2019-04-02 19:58:35 -04:00
J. King
98f6fca7e3 Enforce minimum array size (for now) 2019-04-02 18:37:46 -04:00
J. King
ef1b761f95 Implement most multiple-item context options 
Selecting multiple folder trees will require further effort
 2019-04-02 18:24:20 -04:00
J. King
ba32ad2f17 Add context options for multiple tags, labels, etc 2019-04-02 09:32:31 -04:00
J. King
77efaa7b41 CLI command for exporting OPML and sundry cleanup 2019-04-01 17:24:19 -04:00
J. King
deea294f8a Add export-to-file wrapper for OPML 2019-04-01 16:54:14 -04:00
J. King
35e79d53a9 OPML export fixes, with tests 2019-03-30 10:01:12 -04:00
J. King
d63edf541f Insert folders into OPML before subscriptions 2019-03-29 09:02:39 -04:00
J. King
25b7b47e0a Prototype OPML exporter 2019-03-28 21:53:04 -04:00
J. King
5d994f3dad Normalize Fever input consistently 
Two parameters are undocumented, but other implementations consistently
accept them from clients
 2019-03-28 14:54:31 -04:00
J. King
de615c671a Tests and fixed for Fever feeds and groups 2019-03-27 15:09:04 -04:00
J. King
7faec3b0db Fever fixes 
- Ensure the last refresh time is included in authenticated requests
- Use a partial mock in auth tests so that other processing does not
get in the way of results
- Make sure the group list includes unused groups
- Make sure the update time of subscriptions is correct
 2019-03-27 11:54:47 -04:00
J. King
d8407330a0 Add a function to get when feeds were last updated 
This is an optimization for Fever, which returns this information with
every API call.
 2019-03-26 16:51:44 -04:00
J. King
acb3973149 Prototype implementation of Fever groups and feeds 2019-03-26 08:53:26 -04:00
J. King
9c61f967e3 Correct CLI password clearing 2019-03-25 17:07:28 -04:00
J. King
bf3bf9589f Merge branch 'master' into fever 2019-03-25 14:12:08 -04:00
J. King
1e83350dd0 Version bump 2019-03-25 11:57:31 -04:00
J. King
65f723c7d4 Fix missing reference to author in TT-RSS. 2019-03-25 11:30:35 -04:00
J. King
22c2629078 Partial tests for new CLI features 2019-03-25 10:45:05 -04:00
J. King
7d95e8fc09 Split Fever user management from protocol handler 2019-03-25 08:31:49 -04:00
J. King
1ce95ef4d9 Add means of testing Fever authentication 2019-03-24 15:05:21 -04:00
J. King
e45ba3f0ea Add means of unsetting a password in the backend 2019-03-24 14:42:23 -04:00
J. King
07122b524a Rename Fever user functions for consistency 2019-03-21 10:19:30 -04:00
J. King
9ebaa20633 Tests for Fever password creation and removal 2019-03-20 22:24:35 -04:00
J. King
9168155244 Add method to unset a Fever password 2019-03-20 10:42:04 -04:00
J. King
1e2d595992 Full set of authentication tests for Fever 2019-03-19 23:37:08 -04:00
J. King
d59223bbcb First authentication test for Fever 2019-03-18 22:49:47 -04:00
J. King
b02c910b1e Make token creation check that the user exists 2019-03-10 15:54:43 -04:00
J. King
3aa2b62d02 Basic Fever skeleton 
Authentication should work, but not tests have been written yet
 2019-03-09 22:44:59 -05:00
J. King
38bdde1167 Add access tokens to the db, with relevant code 
Tokens are similar to sessions in that they stand in for users, but the
protocol handlers will manage them; Fever login hashes are the
originating use case for them. These must never expire, for example,
and we need to specify their values.

This commit also performs a bit of database clean-up
 2019-03-09 16:23:56 -05:00
J. King
5de1844f6d Add article selection by tag 2019-03-07 11:07:22 -05:00
J. King
e6f70527cf Simplify tag summary 2019-03-07 08:20:09 -05:00
J. King
ff0c9a3a55 Add functionality for interacting with subscription tags 2019-03-06 22:15:41 -05:00
J. King
e2cba68c1b Clarify various SQL queries 2019-03-05 19:25:46 -05:00
J. King
4945f8baa3 Clarify various SQL queries 2019-03-05 19:22:01 -05:00
J. King
6000d80b7b Work around various SQLite-related problems 
- WAL mode was not getting set properly
- Queries using the PDO driver could fail because PDO sucks
 2019-03-04 11:08:56 -05:00
J. King
ed22090e49 Work around various SQLite-related problems 
- WAL mode was not getting set properly
- Queries using the PDO driver could fail because PDO sucks
 2019-03-04 11:05:46 -05:00
J. King
fb1bdbfb37 Database schema for subscription tags 2019-03-03 12:10:18 -05:00
J. King
5efef2c2d0 Console command to refresh all feeds once; fixes #147 2019-03-02 14:59:44 -05:00
J. King
44366f48bf Remove arbitrary search term limits; fixes #150 2019-03-02 13:53:43 -05:00
J. King
21fdd66d37 Work around limit to SQL parameter placeholders for IN() clauses 
Improves #150

LIKE-based matches also need to be similarly conservative
 2019-03-01 22:36:25 -05:00
J. King
6857e8ec1b Merge branch 'search' 2019-03-01 12:26:08 -05:00
J. King
837f3c6dd6 Simplify SQL type handling 
This is done in anticipation of dealing with SQL types in
places other than statements
 2019-03-01 12:17:33 -05:00
J. King
3b8461b1ca Add searching to TTRSS handler 2019-02-28 16:22:04 -05:00
J. King
85307bc90a Add parser for TTRSS search strings 2019-02-28 15:31:33 -05:00
J. King
95de375e0b Handle folder and label exclusion 
Consequently the way label data are retrieved was completely overhauled
 2019-02-27 10:48:11 -05:00
J. King
1e7724ec80 Filter out duplicates in set context options 2019-02-26 12:54:27 -05:00
J. King
677e33e518 Add text search exclusions 2019-02-26 11:39:19 -05:00
J. King
89f25d7b91 Fix coverage a little 2019-02-26 11:12:40 -05:00
J. King
0dc82f64d5 Allow ranges in exclusion contexts 2019-02-26 11:11:42 -05:00
J. King
70443a5264 Make parent re-association on context clone more restrictive 2019-02-25 23:59:48 -05:00
J. King
18d52ea402 Make exclusion contexts return their parent on change 2019-02-25 23:37:14 -05:00
J. King
b950ac066f Restrict options in not-context and hopefully make it easier to use 2019-02-25 22:41:12 -05:00
J. King
14c02d56ac Implement new context options other than not(). 
Context handling has also been re-organized to simplify later
implementation of the not() option
 2019-02-25 16:26:38 -05:00
J. King
f4a74eec5d Add all the other context options allowed by the TTRSS search syntax 2019-02-25 10:46:43 -05:00
J. King
2df7c25b66 Add ability to search note text 2019-02-23 20:14:52 -05:00
J. King
bc3182a961 Basic substring searching 2019-02-22 18:50:39 -05:00
J. King
570a9b171c Revert fulltext detection in driver 2019-02-22 18:49:57 -05:00
J. King
ace94e3ef8 Fix context, and context tests 2019-02-22 12:34:06 -05:00
J. King
f9fde23708 Context changes to support basic text searching 2019-02-22 11:13:42 -05:00
J. King
ad8057a40b Driver changes to support basic text searching 2019-02-22 11:13:13 -05:00
J. King
908e1fa310 API documentation for database driver interface 2019-02-21 15:43:19 -05:00
J. King
b55d0b374f API documentation for database driver interface 2019-02-21 15:10:32 -05:00
J. King
17f3a2f059 Start on an API overview for the Database class 2019-02-13 12:37:41 -05:00
J. King
b0d5458367 Clarify some prospective protocols 2019-02-04 13:18:33 -05:00
J. King
49cefaf5c8 Complete API documentation for the Database class 2019-02-04 13:05:48 -05:00
J. King
d3a385beef Partial API documentation for the Database class 2019-02-03 12:25:07 -05:00
J. King
b1282b6f6a Upgrade to PHP 7.1 and PHPUnit 7. 2019-01-25 22:07:37 -05:00
J. King
f5c5d49d97 Document SQL timeout changes 2019-01-24 11:40:25 -05:00
J. King
500851f161 Style fixes 2019-01-23 16:34:54 -05:00
J. King
91b6fdc696 Update changelog; bump version 2019-01-23 16:32:48 -05:00
J. King
8ea1df920a Unify SQL timeouts 
- Exec and lock timeouts now apply to MySQL
- Lock timeout now applies to PostgreSQL
- SQLite now uses a generic lock timeout setting which applies to all
 2019-01-23 16:31:54 -05:00
J. King
970731073d Fetch timeout should be a float, not an integer 2019-01-23 09:37:41 -05:00
J. King
9120d3b3e3 Correctly escape shell command in subprocesds service driver 2019-01-23 09:32:44 -05:00
J. King
a5049ac646 Remove reference to PicoFeed in the User-Agent string 
PicoFeed is dead, so there's no point.
 2019-01-23 09:21:35 -05:00
J. King
37131d3775 Remove non-functional curl service driver for now 
Its requiring extensive configuration to function makes me disinclined
to revive it, though it may nevertheless happen.
 2019-01-23 09:19:26 -05:00
J. King
05aadfe7c7 Use correct SQLite chema change procedure; version bump 2019-01-21 10:40:39 -05:00
J. King
5335d331f7 Fix configuration exporting 2019-01-21 09:55:25 -05:00
J. King
5cd84c4ab4 Validate configuration parameters on import, and other changes 
- Each parameter is checked for type and normalized
- Interval strings are converted to DateInterval objects
- Timeouts can be specified as interval strings
- Most intervals can be null to signify infinity
- Driver classes are checked that they implement the correct interface
- Short driver names may be used, and are used by default
- Helpful errors messages are printed in case of erroneous configuration

Exporting is currently broken; this will be fixed in an upcoming commit
 2019-01-20 22:40:49 -05:00
J. King
b0643de21c Add handling of DateInterval objects to ValueInfo 2019-01-17 16:29:42 -05:00
J. King
4670dfc849 Handle connection errors 2019-01-15 10:51:55 -05:00
J. King
e92bda5373 Various changes: 
- Fix handling of binary data and long strings
- Simplify handling of socket connections
- Fix coverage
 2019-01-15 08:58:11 -05:00
J. King
5d61ab0a57 Fixes for MySQL native interface 
Three test failures remain, but these are minor and will be resolved
soon. Handling of binary data is also broken, but given that this works
fine with the PDO driver, there is presumably some correct method.
 2019-01-13 23:17:19 -05:00
J. King
81acba90dc Use strict equality when comparing strings 2019-01-11 10:38:06 -05:00
J. King
c4a41255b0 Experimental native MySQL driver 
No testing has been performed yet, but changes are extensive enough to
warrant a commit. Of particular note:

- SQL states are enumerated in a separate trait to reduce duplication
- PDOStatement is now an abstract class to avoid duplication of
engine-specific error handling
- Error handling has been cleaned up somewhat
 2019-01-10 19:01:32 -05:00
J. King
206cca35a9 Test tweaks 2018-12-21 17:51:49 -05:00
J. King
5a133b795a Correctly munge MySQL queries 2018-12-21 17:37:22 -05:00
J. King
b4de56a64e Work around MySQL silliness with same-table foreign keys 2018-12-21 17:02:34 -05:00
J. King
f0d30c2eee Make munging of queries a generic feature 2018-12-21 12:35:10 -05:00
J. King
24df564045 Mostly successful MySQL database function tests 
Two failures remain, at least one requiring query munging.
 2018-12-21 10:14:26 -05:00
J. King
de07352fd0 Syntactic adjustments for MySQL 
- "key", "read", and "rename" are reserved words
- CTEs in INSERTs must precede SELECT
- Empty sets are represented only by explicit null
 2018-12-20 21:23:06 -05:00
J. King
393b4e95ad Adjustments for MySQL 8 
The prototype had been tested against MariaDB
 2018-12-20 20:50:56 -05:00
J. King
4ef36643a4 Proof-of-concept PDO MySQL driver 
- Configuration options were added
- Non-transactional locking was added to the savepoint handlers
- Tests were adjusted for MySQL's reserved words
 2018-12-20 18:06:28 -05:00
J. King
50f92625ef Use PosgreSQL's existing general Unicode collation 
All collations appear to be case-insensitive
 2018-12-14 09:18:56 -05:00
J. King
2bebdd44cf Implementation of native PostgreSQL interface 
Changes to the Database class were required to avoid outputting booleans
 2018-12-13 19:47:51 -05:00
J. King
161f5f08f6 Proactively support SQLite 3.25 2018-12-12 12:21:28 -05:00
J. King
28f803dd28 Handle PostgreSQL connection errors 2018-12-12 11:15:07 -05:00
J. King
0f48ce6f37 Use a Unicode collation for SQLite 2018-12-11 14:14:32 -05:00
J. King
35d46d2913 Use persistent connections with PostgreSQL 2018-12-10 12:28:43 -05:00
J. King
f6966659a9 Use smarter coverage executer; properly suppress stderr during CLI tests 2018-12-07 20:25:48 -05:00
J. King
0513b606c2 Merge master 2018-12-07 19:21:44 -05:00
J. King
089f666de6 Fix PDO insert ID errors in PHP 7.1 2018-12-06 17:46:00 -05:00
J. King
cf896121b2 Style fixes 2018-12-05 17:28:11 -05:00
J. King
51755a2ce6 Retire article field groups 2018-12-05 16:55:14 -05:00
J. King
15301cd7dc Fix cleanup tests in PostgreSQL 2018-12-05 11:05:01 -05:00
J. King
258be1d54e Fix most PostgreSQL test failures 
Reasons for failures included an unhandled error code, erroneous sorting
assumptions, and a broken computation of the next insert ID in tests

Five failures remain.
 2018-12-05 09:05:43 -05:00
J. King
8fc31cfc40 Rewrite various queries to work in PostgreSQL 
This involved changes to the driver interface as well as the database
schemata. The most significantly altered queries were for article
selection and marking, which relied upon unusual features of SQLite.
Overall query efficiency should not be adversely affected (it may have
even imprved) in the common case, while very rare cases (not presently
triggered by any REST handlers) require more queries.

One notable benefit of these changes is that functions which query
articles can now have complete control over which columns are returned.
This has not, however, been implemented yet: symbolic column groups are
still used for now.

Note that PostgreSQL still fails many tests, but the test suite runs to
completion. Note also that one line of the Database class is not
covered; later changes will eventually make it easier to cover the line
in question.
 2018-12-04 20:41:21 -05:00
J. King
5c5a5a4886 Appease PostgreSQL's max() aggregate 2018-11-29 14:36:34 -05:00
J. King
527ecee393 Code coverage fixes 2018-11-29 13:56:15 -05:00
J. King
4a1c23ba45 Munge PostgreSQL queries instead of adding explicit casts 
PDO does not adequately inform PostgreSQL of a parameter's type, so type
casts are required. Rather than adding these to each query manually, the
queries are instead processed to add type hints automatically.

Unfortunately the queries are processed rather naively; question-mark
characters in string constants, identifiers, regex patterns, or geometry
operators will break things spectacularly.
 2018-11-29 13:45:37 -05:00
J. King
4c8d8f1a52 Provide PostgreSQL with an empty-set query for IN() clauses 
Also satisfy PostgreSQL with some explicit casts
 2018-11-28 17:18:33 -05:00
J. King
dd4f22e04e Avoid use of reserved SQL word "user" 2018-11-28 14:21:36 -05:00
J. King
8dfedd30ef Test PostgreSQL schema upgrade 
This was in fact buggy due to the schema version check causing an error
 2018-11-28 10:46:23 -05:00
J. King
93af381436 Test setting of schema name 2018-11-27 17:39:39 -05:00
J. King
1414f8979c Fix savepoint handling and locking in PostgreSQL driver 2018-11-27 17:16:00 -05:00
J. King
736a8c9d0c Improved timeout handling for both SQlite and PostgreSQL 2018-11-22 13:30:13 -05:00
J. King
c0c4810662 Nominally complete PostgreSQL driver 
Connection error handling as well as uprade error handling still need
to be implemented.
 2018-11-21 11:06:12 -05:00
J. King
84b4cb7465 Enable PostgreSQL statement testing 
Tests involving binary data are skipped for now
 2018-11-20 16:32:18 -05:00
J. King
d52af6db5a PostgreSQL fixes 
Errors were not correctly throwing exceptions

For the sake of SQLite compatibility booleans should be bound as
integers in PDO
 2018-11-20 15:48:03 -05:00
J. King
e2b6cb8360 Remove PicoFeed-related FIXMEs 
PicoFeed will never be fixed, so they are not helpful
 2018-11-20 15:46:22 -05:00
J. King
b5733b070c Clean up statement tests 
PostgreSQL tests are suppressed for now, but most pass.
 2018-11-20 15:45:20 -05:00
J. King
e30d82fbaa Correct signature 2018-11-16 21:35:05 -05:00
J. King
edfae438fa Refine pg connection strings 2018-11-16 21:20:54 -05:00
J. King
796315c00c Basic stub of PDO-base PostgreSQL driver 2018-11-10 00:02:38 -05:00
J. King
3b3b810f10 Replicate some unspecified NCNv1 behaviour, and document the rest 
See #139 for list

Closes #139
Closes #140
Closes #141
 2018-11-07 13:01:46 -05:00
J. King
1dcbb56077 Changelog and documentation updates 2018-11-07 10:24:35 -05:00
J. King
63ae6fb703 Merge remote-tracking branch 'remotes/origin/user-rewrite' 2018-11-06 16:36:50 -05:00
J. King
3a4100576a Merge remote-tracking branch 'remotes/origin/cli-overhaul' 2018-11-06 16:36:35 -05:00
J. King
39134f5f7e Rest of CLI tests 2018-11-06 16:35:33 -05:00
J. King
efac62f0e4 Add missing return type hints where possible 2018-11-06 12:50:26 -05:00
J. King
9e6f0460c2 Ensure the Lang class always exists when throwing exceptions 2018-11-06 12:48:31 -05:00
J. King
ba8e208d79 Partial CLI tests 2018-11-06 12:32:28 -05:00
J. King
1a8acdf03f Fix early exceptions 2018-11-06 09:04:51 -05:00
J. King
9428d7468a Add more user management functionality to the CLI 2018-11-05 09:08:50 -05:00
J. King
a8cc9a4780 Tests for internal user driver; closes #50 2018-11-04 12:06:30 -05:00
J. King
5f775bef7a Appease phpdbg coverage bug 2018-11-03 13:49:02 -04:00
J. King
1ac85df46b Last set of tests for User class 2018-11-03 13:26:22 -04:00
J. King
ffa7bd5a5d Fix error in previous commit 2018-11-02 12:01:03 -04:00
J. King
931fe3b585 Move password generation to the User class 
This allows user drivers which wish to generate their own passwords to
do so, and those which do not to defer to the built-in generator
 2018-11-02 11:52:55 -04:00
J. King
31cdf313a4 Add missing return type hints where possible 2018-11-02 11:47:10 -04:00
J. King
898533bde5 More simplification 
Authentication is now used as the primary point of synchronization
between the internal database and any external database
 2018-11-02 10:01:49 -04:00
J. King
40d679844b Ensure the Lang class always exists when throwing exceptions 2018-10-31 14:32:11 -04:00
J. King
27edcddc9b Simplify NCNv1 userStatus call 2018-10-28 13:59:09 -04:00
J. King
057d72c816 Remove the distinction between internal and external user functionality 2018-10-28 13:50:57 -04:00
J. King
11747c93fd Strip out unused user management functionality 
Tests have been removed as well; new tests are forthcoming
 2018-10-28 10:59:17 -04:00
J. King
0be9dcb5a8 Update dependencies 2018-10-26 16:27:18 -04:00
J. King
f64f0c6a22 Whitespace cleanup 2018-10-26 14:58:04 -04:00
J. King
1aa556cf12 Add HTTP authentication support to TTRSS; fixes #133 
Also bump version to 0.4.0
 2018-10-26 14:40:20 -04:00
J. King
edbfb12d17 Improve coverage slightly 
Improves #66
 2018-08-17 08:35:13 -04:00
J. King
e4d64424c7 Make new bugfix release 2018-07-22 12:30:44 -04:00
J. King
a92bad1bc8 Correctly load configuration 2018-06-18 10:09:43 -04:00
J. King
c7c5f48066 Fix notice 2018-01-24 23:25:54 -05:00
J. King
cbc9491f75 CS fixes and version bump 2018-01-12 09:48:33 -05:00
J. King
34b508171b Merge CORS branch 2018-01-12 09:41:13 -05:00
J. King
1a4989e1e0 Merge PDO branch 2018-01-12 09:28:58 -05:00
J. King
aa57227097 Use PSR-7 for authentication; fixes #53 2018-01-11 15:48:29 -05:00
J. King
90dfeb727a Implement CORS; fixes #126 2018-01-09 12:31:40 -05:00
J. King
0ec0a5b085 Ensure the request method is always uppercased 2018-01-08 17:11:38 -05:00
J. King
4b53c5e8b3 Tests and fixes for REST class; fixes #53; improves #66 2018-01-07 12:59:10 -05:00
J. King
3fa2d38f31 Initial rewrite of REST class; needs more testing, but should be functional 
- improves #53
- improves #66
 2018-01-06 12:02:45 -05:00
J. King
890f9b07d4 Replace Resquest objects with PSR-7 request messages; improves #53 2018-01-04 23:08:53 -05:00
J. King
9ad0b47201 Add Target class to manipulate request traget URL parts 
The query part is not parsed for now because PSR-7 request objects/PHP take care of that parsing for us.
 2018-01-04 14:06:45 -05:00
J. King
9eadd602bd Replace Response objects with PSR-7 response messages; improves #53 
While the test suite passes, this commit yields a broken server: replacing ad hoc request objectss with PSR-7 ones is still required, as is emission of PSR-7 responses. Both will come in subsequent commits, with tests

Diactoros was chosen specifically because it includes facilities for emitting responses, something which is awkward to test. The end of this refactoring should see both the Response and Request classes disappear, and the general REST class fully covered (as well as any speculative additions to AbstractHanlder).
 2018-01-03 23:13:08 -05:00
J. King
27caf147df Changes to Date helper class 
- Changed 'transform' method to use ValueInfo throughout. This fixes a number of obscure bugs
- Changed the 'add' and 'sub' methods to default to "now" rather than null. This means null passes through rather than being interpreted as the current time, to be consistent with other date tools
- Also changed the 'add' and 'sub' methods so that they operate correctly with invalid date strings
- Added tests for the class; improves #66
- Modified TTRSS tests because the "iso8601" format string in ValueInfo is different from Date's older format
 2018-01-02 16:53:38 -05:00
J. King
89bfc23d32 Standardize date normalization to immutables 
Also move date formats to the ValueInfo class

Standardizing on immutables avoids any possible ambiguity in the API of the resultant value, as well as any ambiguity as to whether a DateTime output instance is the same instance or a clone (they had been clones)
 2018-01-02 16:27:58 -05:00
J. King
87faededc6 Backport PDO changes to ValueInfo 2018-01-02 10:29:24 -05:00
J. King
ddf55e0665 Change session lifetimes to more closely match TTRSS 
At least some clients seem to expect the default timeout of one day.
 2018-01-01 12:31:42 -05:00
J. King
77793f95cb Controller fixes for PDO databases; fixes #72 2017-12-31 17:24:40 -05:00
J. King
ba0aeab7ec Make SQL statement type conversion use ValueInfo normalizer 
This sees the addition of a dateOutFormat parameter to ValueInfo::normalize(), as well as a general simplification of how parameter binding works.

Some value type-casting results are slightly different, but this simply makes SQL statement objects consistent with the rest of the system.
 2017-12-30 18:50:56 -05:00
J. King
bc9fcb975f Change "rebind" to "retype" to better reflect what actually happens 2017-12-30 17:04:21 -05:00
J. King
bc9ffa0e17 Rewrite SQLite 3 type binding tests 2017-12-30 15:59:45 -05:00
J. King
39cad91b78 CS fixes 2017-12-22 11:51:58 -05:00
J. King
4bada691e9 PDO tests and fixes; improves #72 2017-12-19 19:08:08 -05:00
J. King
ad6a09ffa1 Partially tested pdo_sqlite driver; improves #72 2017-12-19 17:15:05 -05:00
J. King
ef75b5e9ab SQLite driver tweaks 2017-12-19 12:11:49 -05:00
J. King
7ca0f4e877 Make the SQLite3 driver more generic 
The changes in this commit should make it more practical to:

- Allow the driver to decide for itself whether to try creating a PDO object if its own requirements are not met
- Have any driver use a generic schema update procedure
- Use the same constructor for native and PDO SQLite
 2017-12-18 18:29:32 -05:00
J. King
73c8583744 Remove reliance on xdebug; fixes #113 
Code coverage information is now gathered via phpdbg (a separate executable) by if available rather than xdebug, as the latter is hard to turn on and off.

A "test:quick" task has also been added to Robo, which excludes 31 tests which together account for almost two thirds of the test run time. This should pave the way for testing to be added as a commit hook for Git.
 2017-12-17 10:27:34 -05:00
Dustin Wilson
b8ed7c6bf8 Added missing static keyword to Misc\ValueInfo::normalize() 2017-12-10 11:16:06 -06:00
J. King
f100cab558 Version bump 2017-12-07 18:24:35 -05:00
J. King
44ae0ba29b Collate synthetic subscription title column; fixes #127 2017-12-07 18:17:16 -05:00
J. King
0b3b3cb49c Use SQLite nocase collation; improves #127 2017-12-07 18:05:34 -05:00
J. King
79f9808f1f CS fixes 2017-12-07 15:18:25 -05:00
J. King
8d0dd15c8a Remove use of SQLite IS operator; fixes #120 2017-12-06 22:26:06 -05:00
J. King
84bd624e94 Properly fix getCounters 2017-12-06 19:16:35 -05:00
J. King
af42bceac0 Do not omit zero-unread items in TTRSS getCounter operation 
Though TTRSS itself (usually) omits items that have a counter of zero, at least one client takes this to mean the last-seen counter is unchanged, rather than zero.
 2017-12-06 15:50:40 -05:00
J. King
adece521a9 TTRSS: Correct mark toggling; fixes #132 2017-12-01 22:13:27 -05:00
J. King
821bb22a72 SQLite concurrency tweaks; fixes #131 2017-12-01 16:37:58 -05:00
J. King
1a9628493e Fix TTRSS path handling 2017-11-30 19:39:46 -05:00
J. King
9ac2421fe3 TTRSS: accept base64 passwords; fixes #130 2017-11-30 19:31:40 -05:00
J. King
3ffcd6dd97 Make TTRSS handler reject erroneous paths 2017-11-30 17:54:56 -05:00
J. King
a404d4d108 NCNv1: Be explicit about types; fixes #129 
This is actually mandated by the specification: a change in data type requires a protocol version number change
 2017-11-30 14:47:39 -05:00
J. King
4d4e8e3580 TTRSS: correct feed renaming; fixes #128 2017-11-30 12:49:23 -05:00
J. King
760b13993b Version bump 2017-11-29 23:45:27 -05:00
J. King
22cdc8916d Documentation tweaks and CS fixes 2017-11-29 22:42:50 -05:00
J. King
5cd7268c0a Added incorrectDbCharset to NCNv1 server status 
This has been exposed since version 11.0.3, released before our version 0.1.0, but after implementation work had begun
 2017-11-29 18:14:59 -05:00
J. King
40944a9b58 Merge remote-tracking branch 'remotes/origin/ttrss' 2017-11-29 16:05:23 -05:00
J. King
3d958547a5 Implement OPTIONS requests for NCNv1; fixes #107 2017-11-29 15:28:33 -05:00
J. King
e1f1c8b859 Refactoring 2017-11-29 13:41:26 -05:00
J. King
2bbc83aeb0 Tweak 2017-11-29 12:15:37 -05:00
J. King
40e9b7f986 Changed all TTRSS outputs to match original types exactly; improves #125 2017-11-29 11:47:10 -05:00
J. King
b4890eaced Make TTRSS tests consider data types; improves #125 2017-11-29 09:22:59 -05:00