mirror/Arsse
1
1
Fork 0
mirror of https://code.mensbeam.com/MensBeam/Arsse.git synced 2024-12-22 21:22:40 +00:00
Code Issues Activity

Remove PicoFeed-related FIXMEs

Browse source 
PicoFeed will never be fixed, so they are not helpful
This commit is contained in:
J. King 2018-11-20 15:46:22 -05:00
parent b5733b070c
commit e2b6cb8360
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/Feed.php
View file

@ -33,14 +33,14 @@ class Feed {
} else { } else {
$links = $f->reader->find($f->getUrl(), $f->getContent()); $links = $f->reader->find($f->getUrl(), $f->getContent());
if (!$links) { if (!$links) {
// work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory // work around a PicoFeed memory leak
libxml_use_internal_errors(false); libxml_use_internal_errors(false);
throw new Feed\Exception($url, new \PicoFeed\Reader\SubscriptionNotFoundException('Unable to find a subscription')); throw new Feed\Exception($url, new \PicoFeed\Reader\SubscriptionNotFoundException('Unable to find a subscription'));
} else { } else {
$out = $links[0]; $out = $links[0];
} }
} }
// work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory // work around a PicoFeed memory leak
libxml_use_internal_errors(false); libxml_use_internal_errors(false);
return $out; return $out;
} }
@ -115,10 +115,10 @@ class Feed {
// Some feeds might use a different domain (eg: feedburner), so the site url is // Some feeds might use a different domain (eg: feedburner), so the site url is
// used instead of the feed's url. // used instead of the feed's url.
$this->favicon = (new Favicon)->find($feed->siteUrl); $this->favicon = (new Favicon)->find($feed->siteUrl);
// work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory // work around a PicoFeed memory leak
libxml_use_internal_errors(false); libxml_use_internal_errors(false);
} catch (PicoFeedException $e) { } catch (PicoFeedException $e) {
// work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory // work around a PicoFeed memory leak
libxml_use_internal_errors(false); libxml_use_internal_errors(false);
throw new Feed\Exception($this->resource->getUrl(), $e); throw new Feed\Exception($this->resource->getUrl(), $e);
} }