From e2b6cb83600395de15ee1d3470c6f6c696b2273d Mon Sep 17 00:00:00 2001 From: "J. King" Date: Tue, 20 Nov 2018 15:46:22 -0500 Subject: [PATCH] Remove PicoFeed-related FIXMEs PicoFeed will never be fixed, so they are not helpful --- lib/Feed.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Feed.php b/lib/Feed.php index 836ecc86..9ede4e4b 100644 --- a/lib/Feed.php +++ b/lib/Feed.php @@ -33,14 +33,14 @@ class Feed { } else { $links = $f->reader->find($f->getUrl(), $f->getContent()); if (!$links) { - // work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory + // work around a PicoFeed memory leak libxml_use_internal_errors(false); throw new Feed\Exception($url, new \PicoFeed\Reader\SubscriptionNotFoundException('Unable to find a subscription')); } else { $out = $links[0]; } } - // work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory + // work around a PicoFeed memory leak libxml_use_internal_errors(false); return $out; } @@ -115,10 +115,10 @@ class Feed { // Some feeds might use a different domain (eg: feedburner), so the site url is // used instead of the feed's url. $this->favicon = (new Favicon)->find($feed->siteUrl); - // work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory + // work around a PicoFeed memory leak libxml_use_internal_errors(false); } catch (PicoFeedException $e) { - // work around a PicoFeed memory leak FIXME: remove this hack (or not) once PicoFeed stops leaking memory + // work around a PicoFeed memory leak libxml_use_internal_errors(false); throw new Feed\Exception($this->resource->getUrl(), $e); }