J. King
81acba90dc
Use strict equality when comparing strings
2019-01-11 10:38:06 -05:00
J. King
c4a41255b0
Experimental native MySQL driver
...
No testing has been performed yet, but changes are extensive enough to
warrant a commit. Of particular note:
- SQL states are enumerated in a separate trait to reduce duplication
- PDOStatement is now an abstract class to avoid duplication of
engine-specific error handling
- Error handling has been cleaned up somewhat
2019-01-10 19:01:32 -05:00
J. King
206cca35a9
Test tweaks
2018-12-21 17:51:49 -05:00
J. King
5a133b795a
Correctly munge MySQL queries
2018-12-21 17:37:22 -05:00
J. King
b4de56a64e
Work around MySQL silliness with same-table foreign keys
2018-12-21 17:02:34 -05:00
J. King
f0d30c2eee
Make munging of queries a generic feature
2018-12-21 12:35:10 -05:00
J. King
24df564045
Mostly successful MySQL database function tests
...
Two failures remain, at least one requiring query munging.
2018-12-21 10:14:26 -05:00
J. King
de07352fd0
Syntactic adjustments for MySQL
...
- "key", "read", and "rename" are reserved words
- CTEs in INSERTs must precede SELECT
- Empty sets are represented only by explicit null
2018-12-20 21:23:06 -05:00
J. King
393b4e95ad
Adjustments for MySQL 8
...
The prototype had been tested against MariaDB
2018-12-20 20:50:56 -05:00
J. King
4ef36643a4
Proof-of-concept PDO MySQL driver
...
- Configuration options were added
- Non-transactional locking was added to the savepoint handlers
- Tests were adjusted for MySQL's reserved words
2018-12-20 18:06:28 -05:00
J. King
50f92625ef
Use PosgreSQL's existing general Unicode collation
...
All collations appear to be case-insensitive
2018-12-14 09:18:56 -05:00
J. King
2bebdd44cf
Implementation of native PostgreSQL interface
...
Changes to the Database class were required to avoid outputting booleans
2018-12-13 19:47:51 -05:00
J. King
161f5f08f6
Proactively support SQLite 3.25
2018-12-12 12:21:28 -05:00
J. King
28f803dd28
Handle PostgreSQL connection errors
2018-12-12 11:15:07 -05:00
J. King
0f48ce6f37
Use a Unicode collation for SQLite
2018-12-11 14:14:32 -05:00
J. King
35d46d2913
Use persistent connections with PostgreSQL
2018-12-10 12:28:43 -05:00
J. King
f6966659a9
Use smarter coverage executer; properly suppress stderr during CLI tests
2018-12-07 20:25:48 -05:00
J. King
0513b606c2
Merge master
2018-12-07 19:21:44 -05:00
J. King
089f666de6
Fix PDO insert ID errors in PHP 7.1
2018-12-06 17:46:00 -05:00
J. King
cf896121b2
Style fixes
2018-12-05 17:28:11 -05:00
J. King
51755a2ce6
Retire article field groups
2018-12-05 16:55:14 -05:00
J. King
15301cd7dc
Fix cleanup tests in PostgreSQL
2018-12-05 11:05:01 -05:00
J. King
258be1d54e
Fix most PostgreSQL test failures
...
Reasons for failures included an unhandled error code, erroneous sorting
assumptions, and a broken computation of the next insert ID in tests
Five failures remain.
2018-12-05 09:05:43 -05:00
J. King
8fc31cfc40
Rewrite various queries to work in PostgreSQL
...
This involved changes to the driver interface as well as the database
schemata. The most significantly altered queries were for article
selection and marking, which relied upon unusual features of SQLite.
Overall query efficiency should not be adversely affected (it may have
even imprved) in the common case, while very rare cases (not presently
triggered by any REST handlers) require more queries.
One notable benefit of these changes is that functions which query
articles can now have complete control over which columns are returned.
This has not, however, been implemented yet: symbolic column groups are
still used for now.
Note that PostgreSQL still fails many tests, but the test suite runs to
completion. Note also that one line of the Database class is not
covered; later changes will eventually make it easier to cover the line
in question.
2018-12-04 20:41:21 -05:00
J. King
5c5a5a4886
Appease PostgreSQL's max() aggregate
2018-11-29 14:36:34 -05:00
J. King
527ecee393
Code coverage fixes
2018-11-29 13:56:15 -05:00
J. King
4a1c23ba45
Munge PostgreSQL queries instead of adding explicit casts
...
PDO does not adequately inform PostgreSQL of a parameter's type, so type
casts are required. Rather than adding these to each query manually, the
queries are instead processed to add type hints automatically.
Unfortunately the queries are processed rather naively; question-mark
characters in string constants, identifiers, regex patterns, or geometry
operators will break things spectacularly.
2018-11-29 13:45:37 -05:00
J. King
4c8d8f1a52
Provide PostgreSQL with an empty-set query for IN() clauses
...
Also satisfy PostgreSQL with some explicit casts
2018-11-28 17:18:33 -05:00
J. King
dd4f22e04e
Avoid use of reserved SQL word "user"
2018-11-28 14:21:36 -05:00
J. King
8dfedd30ef
Test PostgreSQL schema upgrade
...
This was in fact buggy due to the schema version check causing an error
2018-11-28 10:46:23 -05:00
J. King
93af381436
Test setting of schema name
2018-11-27 17:39:39 -05:00
J. King
1414f8979c
Fix savepoint handling and locking in PostgreSQL driver
2018-11-27 17:16:00 -05:00
J. King
736a8c9d0c
Improved timeout handling for both SQlite and PostgreSQL
2018-11-22 13:30:13 -05:00
J. King
c0c4810662
Nominally complete PostgreSQL driver
...
Connection error handling as well as uprade error handling still need
to be implemented.
2018-11-21 11:06:12 -05:00
J. King
84b4cb7465
Enable PostgreSQL statement testing
...
Tests involving binary data are skipped for now
2018-11-20 16:32:18 -05:00
J. King
d52af6db5a
PostgreSQL fixes
...
Errors were not correctly throwing exceptions
For the sake of SQLite compatibility booleans should be bound as
integers in PDO
2018-11-20 15:48:03 -05:00
J. King
e2b6cb8360
Remove PicoFeed-related FIXMEs
...
PicoFeed will never be fixed, so they are not helpful
2018-11-20 15:46:22 -05:00
J. King
b5733b070c
Clean up statement tests
...
PostgreSQL tests are suppressed for now, but most pass.
2018-11-20 15:45:20 -05:00
J. King
e30d82fbaa
Correct signature
2018-11-16 21:35:05 -05:00
J. King
edfae438fa
Refine pg connection strings
2018-11-16 21:20:54 -05:00
J. King
796315c00c
Basic stub of PDO-base PostgreSQL driver
2018-11-10 00:02:38 -05:00
J. King
3b3b810f10
Replicate some unspecified NCNv1 behaviour, and document the rest
...
See #139 for list
Closes #139
Closes #140
Closes #141
2018-11-07 13:01:46 -05:00
J. King
1dcbb56077
Changelog and documentation updates
2018-11-07 10:24:35 -05:00
J. King
63ae6fb703
Merge remote-tracking branch 'remotes/origin/user-rewrite'
2018-11-06 16:36:50 -05:00
J. King
3a4100576a
Merge remote-tracking branch 'remotes/origin/cli-overhaul'
2018-11-06 16:36:35 -05:00
J. King
39134f5f7e
Rest of CLI tests
2018-11-06 16:35:33 -05:00
J. King
efac62f0e4
Add missing return type hints where possible
2018-11-06 12:50:26 -05:00
J. King
9e6f0460c2
Ensure the Lang class always exists when throwing exceptions
2018-11-06 12:48:31 -05:00
J. King
ba8e208d79
Partial CLI tests
2018-11-06 12:32:28 -05:00
J. King
1a8acdf03f
Fix early exceptions
2018-11-06 09:04:51 -05:00
