mirror/Arsse
1
1
Fork 0
mirror of https://code.mensbeam.com/MensBeam/Arsse.git synced 2024-12-23 09:02:41 +00:00
Code Issues Activity
1338 commits 11 branches 28 tags 4.1 MiB
Commit graph

418 commits

Author SHA1 Message Date
J. King
4ce371ece6 Tests and fixes for Fever item listing 2019-04-08 18:41:56 -04:00
J. King
e3d2215920 Style fixes 2019-04-05 11:03:15 -04:00
J. King
12f23ddc16 Updated tests for arbitrary sorting 2019-04-04 17:21:23 -04:00
J. King
f72c85c9f6 Hopefully working but maybe broken custom sorting 2019-04-04 11:22:50 -04:00
J. King
74fc39fca0 Implement multi-folder context option 2019-04-02 22:44:09 -04:00
J. King
cce1089e10 Handle edge case with folder 0 
Folder 0 (the root folder) is a valid, though nonsensical selection:
using it as a positive option is the same as not using the option at
all, and using it as a negative option necessarily yields an empty set.

However, it can in some contexts be validly specified, and so it should
be handled consistently. It had not been previously, but is now.
 2019-04-02 19:58:35 -04:00
J. King
98f6fca7e3 Enforce minimum array size (for now) 2019-04-02 18:37:46 -04:00
J. King
ef1b761f95 Implement most multiple-item context options 
Selecting multiple folder trees will require further effort
 2019-04-02 18:24:20 -04:00
J. King
ba32ad2f17 Add context options for multiple tags, labels, etc 2019-04-02 09:32:31 -04:00
J. King
77efaa7b41 CLI command for exporting OPML and sundry cleanup 2019-04-01 17:24:19 -04:00
J. King
deea294f8a Add export-to-file wrapper for OPML 2019-04-01 16:54:14 -04:00
J. King
35e79d53a9 OPML export fixes, with tests 2019-03-30 10:01:12 -04:00
J. King
de615c671a Tests and fixed for Fever feeds and groups 2019-03-27 15:09:04 -04:00
J. King
7faec3b0db Fever fixes 
- Ensure the last refresh time is included in authenticated requests
- Use a partial mock in auth tests so that other processing does not
get in the way of results
- Make sure the group list includes unused groups
- Make sure the update time of subscriptions is correct
 2019-03-27 11:54:47 -04:00
J. King
d8407330a0 Add a function to get when feeds were last updated 
This is an optimization for Fever, which returns this information with
every API call.
 2019-03-26 16:51:44 -04:00
J. King
9c61f967e3 Correct CLI password clearing 2019-03-25 17:07:28 -04:00
J. King
54be5997d1 CLI tests for password changing and clearing 2019-03-25 15:03:41 -04:00
J. King
a7fe879174 Fix CLI auth test 2019-03-25 14:24:58 -04:00
J. King
22c2629078 Partial tests for new CLI features 2019-03-25 10:45:05 -04:00
J. King
7d95e8fc09 Split Fever user management from protocol handler 2019-03-25 08:31:49 -04:00
J. King
1ce95ef4d9 Add means of testing Fever authentication 2019-03-24 15:05:21 -04:00
J. King
e45ba3f0ea Add means of unsetting a password in the backend 2019-03-24 14:42:23 -04:00
J. King
94314f3e6d Fix test errors when PostgreSQL or MySQL are not available 2019-03-21 15:51:26 -04:00
J. King
fe008d4343 A few more Fever authentication tests 2019-03-21 13:49:55 -04:00
J. King
3b28634447 Verify even in exceptional cases 2019-03-21 11:00:07 -04:00
J. King
07122b524a Rename Fever user functions for consistency 2019-03-21 10:19:30 -04:00
J. King
9ebaa20633 Tests for Fever password creation and removal 2019-03-20 22:24:35 -04:00
J. King
1e2d595992 Full set of authentication tests for Fever 2019-03-19 23:37:08 -04:00
J. King
d59223bbcb First authentication test for Fever 2019-03-18 22:49:47 -04:00
J. King
b02c910b1e Make token creation check that the user exists 2019-03-10 15:54:43 -04:00
J. King
38bdde1167 Add access tokens to the db, with relevant code 
Tokens are similar to sessions in that they stand in for users, but the
protocol handlers will manage them; Fever login hashes are the
originating use case for them. These must never expire, for example,
and we need to specify their values.

This commit also performs a bit of database clean-up
 2019-03-09 16:23:56 -05:00
J. King
5de1844f6d Add article selection by tag 2019-03-07 11:07:22 -05:00
J. King
e6f70527cf Simplify tag summary 2019-03-07 08:20:09 -05:00
J. King
ff0c9a3a55 Add functionality for interacting with subscription tags 2019-03-06 22:15:41 -05:00
J. King
4945f8baa3 Clarify various SQL queries 2019-03-05 19:22:01 -05:00
J. King
ed22090e49 Work around various SQLite-related problems 
- WAL mode was not getting set properly
- Queries using the PDO driver could fail because PDO sucks
 2019-03-04 11:05:46 -05:00
J. King
5efef2c2d0 Console command to refresh all feeds once; fixes #147 2019-03-02 14:59:44 -05:00
J. King
44366f48bf Remove arbitrary search term limits; fixes #150 2019-03-02 13:53:43 -05:00
J. King
21fdd66d37 Work around limit to SQL parameter placeholders for IN() clauses 
Improves #150

LIKE-based matches also need to be similarly conservative
 2019-03-01 22:36:25 -05:00
J. King
6857e8ec1b Merge branch 'search' 2019-03-01 12:26:08 -05:00
J. King
837f3c6dd6 Simplify SQL type handling 
This is done in anticipation of dealing with SQL types in
places other than statements
 2019-03-01 12:17:33 -05:00
J. King
3b8461b1ca Add searching to TTRSS handler 2019-02-28 16:22:04 -05:00
J. King
85307bc90a Add parser for TTRSS search strings 2019-02-28 15:31:33 -05:00
J. King
95de375e0b Handle folder and label exclusion 
Consequently the way label data are retrieved was completely overhauled
 2019-02-27 10:48:11 -05:00
J. King
677e33e518 Add text search exclusions 2019-02-26 11:39:19 -05:00
J. King
0dc82f64d5 Allow ranges in exclusion contexts 2019-02-26 11:11:42 -05:00
J. King
18d52ea402 Make exclusion contexts return their parent on change 2019-02-25 23:37:14 -05:00
J. King
b950ac066f Restrict options in not-context and hopefully make it easier to use 2019-02-25 22:41:12 -05:00
J. King
14c02d56ac Implement new context options other than not(). 
Context handling has also been re-organized to simplify later
implementation of the not() option
 2019-02-25 16:26:38 -05:00
J. King
f4a74eec5d Add all the other context options allowed by the TTRSS search syntax 2019-02-25 10:46:43 -05:00
J. King
2df7c25b66 Add ability to search note text 2019-02-23 20:14:52 -05:00
J. King
bc3182a961 Basic substring searching 2019-02-22 18:50:39 -05:00
J. King
ace94e3ef8 Fix context, and context tests 2019-02-22 12:34:06 -05:00
J. King
500851f161 Style fixes 2019-01-23 16:34:54 -05:00
J. King
8ea1df920a Unify SQL timeouts 
- Exec and lock timeouts now apply to MySQL
- Lock timeout now applies to PostgreSQL
- SQLite now uses a generic lock timeout setting which applies to all
 2019-01-23 16:31:54 -05:00
J. King
5335d331f7 Fix configuration exporting 2019-01-21 09:55:25 -05:00
J. King
5cd84c4ab4 Validate configuration parameters on import, and other changes 
- Each parameter is checked for type and normalized
- Interval strings are converted to DateInterval objects
- Timeouts can be specified as interval strings
- Most intervals can be null to signify infinity
- Driver classes are checked that they implement the correct interface
- Short driver names may be used, and are used by default
- Helpful errors messages are printed in case of erroneous configuration

Exporting is currently broken; this will be fixed in an upcoming commit
 2019-01-20 22:40:49 -05:00
J. King
b0643de21c Add handling of DateInterval objects to ValueInfo 2019-01-17 16:29:42 -05:00
J. King
4670dfc849 Handle connection errors 2019-01-15 10:51:55 -05:00
J. King
e92bda5373 Various changes: 
- Fix handling of binary data and long strings
- Simplify handling of socket connections
- Fix coverage
 2019-01-15 08:58:11 -05:00
J. King
f3b0c791f8 Fix remaining tests 2019-01-14 09:51:00 -05:00
J. King
5d61ab0a57 Fixes for MySQL native interface 
Three test failures remain, but these are minor and will be resolved
soon. Handling of binary data is also broken, but given that this works
fine with the PDO driver, there is presumably some correct method.
 2019-01-13 23:17:19 -05:00
J. King
e501fbdc87 Remove the DatabaseInformation class in tests and use traits instead 2019-01-12 12:43:06 -05:00
J. King
81acba90dc Use strict equality when comparing strings 2019-01-11 10:38:06 -05:00
J. King
206cca35a9 Test tweaks 2018-12-21 17:51:49 -05:00
J. King
f0d30c2eee Make munging of queries a generic feature 2018-12-21 12:35:10 -05:00
J. King
24df564045 Mostly successful MySQL database function tests 
Two failures remain, at least one requiring query munging.
 2018-12-21 10:14:26 -05:00
J. King
4ef36643a4 Proof-of-concept PDO MySQL driver 
- Configuration options were added
- Non-transactional locking was added to the savepoint handlers
- Tests were adjusted for MySQL's reserved words
 2018-12-20 18:06:28 -05:00
J. King
29e7c1f154 Fix coverage 2018-12-13 19:56:07 -05:00
J. King
2bebdd44cf Implementation of native PostgreSQL interface 
Changes to the Database class were required to avoid outputting booleans
 2018-12-13 19:47:51 -05:00
J. King
b52dadf345 Make existing PostgreSQL tests explicitly PDO tests 2018-12-12 12:42:40 -05:00
J. King
28f803dd28 Handle PostgreSQL connection errors 2018-12-12 11:15:07 -05:00
J. King
73729a6be8 Simplify database cleanup between tests 2018-12-10 13:17:04 -05:00
J. King
8dbf237626 Group PostgreSQL tests as slow 2018-12-10 12:39:09 -05:00
J. King
913cf71620 Fix incorrect annotations 2018-12-07 20:36:20 -05:00
J. King
f6966659a9 Use smarter coverage executer; properly suppress stderr during CLI tests 2018-12-07 20:25:48 -05:00
J. King
0513b606c2 Merge master 2018-12-07 19:21:44 -05:00
J. King
089f666de6 Fix PDO insert ID errors in PHP 7.1 2018-12-06 17:46:00 -05:00
J. King
cf896121b2 Style fixes 2018-12-05 17:28:11 -05:00
J. King
f2245861e3 Restore complete Database coverage 
Also suppress PostgreSQL database function tests from normal coverage,
and add a "coverage:full" task to run them if needed.
 2018-12-05 17:07:47 -05:00
J. King
51755a2ce6 Retire article field groups 2018-12-05 16:55:14 -05:00
J. King
0129965bbd Cover some missed code 2018-12-05 12:54:19 -05:00
J. King
22941f5ad1 Fix session tests 
PostgreSQL now passes all tests. Connection and permission errors still
need to be accounted
for before the implementation is complete.
 2018-12-05 12:07:45 -05:00
J. King
258be1d54e Fix most PostgreSQL test failures 
Reasons for failures included an unhandled error code, erroneous sorting
assumptions, and a broken computation of the next insert ID in tests

Five failures remain.
 2018-12-05 09:05:43 -05:00
J. King
8fc31cfc40 Rewrite various queries to work in PostgreSQL 
This involved changes to the driver interface as well as the database
schemata. The most significantly altered queries were for article
selection and marking, which relied upon unusual features of SQLite.
Overall query efficiency should not be adversely affected (it may have
even imprved) in the common case, while very rare cases (not presently
triggered by any REST handlers) require more queries.

One notable benefit of these changes is that functions which query
articles can now have complete control over which columns are returned.
This has not, however, been implemented yet: symbolic column groups are
still used for now.

Note that PostgreSQL still fails many tests, but the test suite runs to
completion. Note also that one line of the Database class is not
covered; later changes will eventually make it easier to cover the line
in question.
 2018-12-04 20:41:21 -05:00
J. King
527ecee393 Code coverage fixes 2018-11-29 13:56:15 -05:00
J. King
4a1c23ba45 Munge PostgreSQL queries instead of adding explicit casts 
PDO does not adequately inform PostgreSQL of a parameter's type, so type
casts are required. Rather than adding these to each query manually, the
queries are instead processed to add type hints automatically.

Unfortunately the queries are processed rather naively; question-mark
characters in string constants, identifiers, regex patterns, or geometry
operators will break things spectacularly.
 2018-11-29 13:45:37 -05:00
J. King
e68fcc0afa Manipulate only those sequences in the current PostgreSQL schema 2018-11-28 17:16:03 -05:00
J. King
4a2efd9987 Correct the state of PostgreSQL serial sequence during tests 2018-11-28 16:24:12 -05:00
J. King
dd4f22e04e Avoid use of reserved SQL word "user" 2018-11-28 14:21:36 -05:00
J. King
10b228224d Correct PostgreSQL data format and other tweaks 2018-11-28 12:12:49 -05:00
J. King
8dfedd30ef Test PostgreSQL schema upgrade 
This was in fact buggy due to the schema version check causing an error
 2018-11-28 10:46:23 -05:00
J. King
1414f8979c Fix savepoint handling and locking in PostgreSQL driver 2018-11-27 17:16:00 -05:00
J. King
8a49202036 Use common cleanup code for all database-related tests 2018-11-27 14:26:33 -05:00
J. King
a75fad53ca Adapt the rest of the test series 2018-11-25 00:03:56 -05:00
J. King
dccd4caede Convert one database function test series (articles) to a common harness 
Also revert the dropping of tables in the schema files. This was for the
convenience of tests, but the risk of data loss is too great
 2018-11-24 23:18:17 -05:00
J. King
7340d65c0e Make data clearing in tests static 2018-11-23 10:01:17 -05:00
J. King
39110858b7 Move database function test series as first step in re-organization 2018-11-23 09:29:06 -05:00
J. King
8c20411359 Align statement tests with other database driver tests 2018-11-22 23:18:20 -05:00
J. King
f22e53fdc9 Align result tests with driver tests 2018-11-22 19:55:54 -05:00
J. King
aa1b65b5d4 Take a different tack on shared database tests 
Tests for different drivers will have their own files, but all derive
from a common prototype test series where applicable, similar to the
existing arrangement for database function tests. However, the prototype
will reside with other test cases rather than in the library path. The
database function test series will hopefully be moved as well in time.
 2018-11-22 13:55:57 -05:00
J. King
736a8c9d0c Improved timeout handling for both SQlite and PostgreSQL 2018-11-22 13:30:13 -05:00
J. King
4e444fd86c Generic database interface creation in tests 2018-11-21 13:06:01 -05:00
J. King
c0c4810662 Nominally complete PostgreSQL driver 
Connection error handling as well as uprade error handling still need
to be implemented.
 2018-11-21 11:06:12 -05:00
J. King
84b4cb7465 Enable PostgreSQL statement testing 
Tests involving binary data are skipped for now
 2018-11-20 16:32:18 -05:00
J. King
b5733b070c Clean up statement tests 
PostgreSQL tests are suppressed for now, but most pass.
 2018-11-20 15:45:20 -05:00
J. King
976672de5b Test cleanup 2018-11-16 21:32:27 -05:00
J. King
edfae438fa Refine pg connection strings 2018-11-16 21:20:54 -05:00
J. King
c4ca9149a1 Move Statement tests 2018-11-09 15:01:46 -05:00
J. King
7e11019e83 Consolidate statement tests 2018-11-09 14:58:10 -05:00
J. King
ea6b4c951e Skip Result tests when necessary 2018-11-09 14:56:30 -05:00
J. King
a3dbb08da9 Remove obsolete test code 2018-11-08 16:29:46 -05:00
J. King
30d6f6db37 Consolidate Db result test series into single file 2018-11-08 14:50:58 -05:00
J. King
3b3b810f10 Replicate some unspecified NCNv1 behaviour, and document the rest 
See #139 for list

Closes #139
Closes #140
Closes #141
 2018-11-07 13:01:46 -05:00
J. King
63ae6fb703 Merge remote-tracking branch 'remotes/origin/user-rewrite' 2018-11-06 16:36:50 -05:00
J. King
3a4100576a Merge remote-tracking branch 'remotes/origin/cli-overhaul' 2018-11-06 16:36:35 -05:00
J. King
39134f5f7e Rest of CLI tests 2018-11-06 16:35:33 -05:00
J. King
4869559fb3 Test NCNv1 user query 2018-11-06 13:21:53 -05:00
J. King
2dd1b45d3e Cover the Query class with database tests for now 2018-11-06 12:51:34 -05:00
J. King
ba8e208d79 Partial CLI tests 2018-11-06 12:32:28 -05:00
J. King
a8cc9a4780 Tests for internal user driver; closes #50 2018-11-04 12:06:30 -05:00
J. King
d40243a84c Clean up configuration setting in tests 2018-11-04 09:16:34 -05:00
J. King
1ac85df46b Last set of tests for User class 2018-11-03 13:26:22 -04:00
J. King
b8f8a617fe Simply user test data providers 
The user manager no longer differentiates between the internal driver
and other drivers, making the duplication unnecessary
 2018-11-02 17:28:12 -04:00
J. King
a52b985826 Cover the Query class with database tests for now 2018-11-02 12:14:46 -04:00
J. King
5959c0672d Tests for most of the User class 2018-11-02 10:02:37 -04:00
J. King
11747c93fd Strip out unused user management functionality 
Tests have been removed as well; new tests are forthcoming
 2018-10-28 10:59:17 -04:00
J. King
0be9dcb5a8 Update dependencies 2018-10-26 16:27:18 -04:00
J. King
e08d82f855 Style fix 2018-10-26 14:58:36 -04:00
J. King
f64f0c6a22 Whitespace cleanup 2018-10-26 14:58:04 -04:00
J. King
1aa556cf12 Add HTTP authentication support to TTRSS; fixes #133 
Also bump version to 0.4.0
 2018-10-26 14:40:20 -04:00
J. King
b4b2b10db3 Cover fatal exception; improves #66 2018-08-17 10:34:54 -04:00
J. King
edbfb12d17 Improve coverage slightly 
Improves #66
 2018-08-17 08:35:13 -04:00
J. King
cbc9491f75 CS fixes and version bump 2018-01-12 09:48:33 -05:00
J. King
34b508171b Merge CORS branch 2018-01-12 09:41:13 -05:00
J. King
1a4989e1e0 Merge PDO branch 2018-01-12 09:28:58 -05:00
J. King
cef061f6cd Fix tests 2018-01-11 16:00:56 -05:00
J. King
aa57227097 Use PSR-7 for authentication; fixes #53 2018-01-11 15:48:29 -05:00
J. King
daea0ceb27 Make HTTP message testing generic 
assertMessage will test the method and target URL of requests, attributes of server requests, as well as the existing testing of a response's status code. All messages' bodies and header fields are tested for equivalence (with a special case for JSON response bodies).
 2018-01-11 11:09:25 -05:00
J. King
90dfeb727a Implement CORS; fixes #126 2018-01-09 12:31:40 -05:00
J. King
0ec0a5b085 Ensure the request method is always uppercased 2018-01-08 17:11:38 -05:00
J. King
4b53c5e8b3 Tests and fixes for REST class; fixes #53; improves #66 2018-01-07 12:59:10 -05:00
J. King
3fa2d38f31 Initial rewrite of REST class; needs more testing, but should be functional 
- improves #53
- improves #66
 2018-01-06 12:02:45 -05:00
J. King
890f9b07d4 Replace Resquest objects with PSR-7 request messages; improves #53 2018-01-04 23:08:53 -05:00
J. King
9ad0b47201 Add Target class to manipulate request traget URL parts 
The query part is not parsed for now because PSR-7 request objects/PHP take care of that parsing for us.
 2018-01-04 14:06:45 -05:00
J. King
9eadd602bd Replace Response objects with PSR-7 response messages; improves #53 
While the test suite passes, this commit yields a broken server: replacing ad hoc request objectss with PSR-7 ones is still required, as is emission of PSR-7 responses. Both will come in subsequent commits, with tests

Diactoros was chosen specifically because it includes facilities for emitting responses, something which is awkward to test. The end of this refactoring should see both the Response and Request classes disappear, and the general REST class fully covered (as well as any speculative additions to AbstractHanlder).
 2018-01-03 23:13:08 -05:00
J. King
27caf147df Changes to Date helper class 
- Changed 'transform' method to use ValueInfo throughout. This fixes a number of obscure bugs
- Changed the 'add' and 'sub' methods to default to "now" rather than null. This means null passes through rather than being interpreted as the current time, to be consistent with other date tools
- Also changed the 'add' and 'sub' methods so that they operate correctly with invalid date strings
- Added tests for the class; improves #66
- Modified TTRSS tests because the "iso8601" format string in ValueInfo is different from Date's older format
 2018-01-02 16:53:38 -05:00
J. King
89bfc23d32 Standardize date normalization to immutables 
Also move date formats to the ValueInfo class

Standardizing on immutables avoids any possible ambiguity in the API of the resultant value, as well as any ambiguity as to whether a DateTime output instance is the same instance or a clone (they had been clones)
 2018-01-02 16:27:58 -05:00
J. King
65b08d1735 Tweak 2017-12-31 17:30:30 -05:00
J. King
77793f95cb Controller fixes for PDO databases; fixes #72 2017-12-31 17:24:40 -05:00
J. King
029c23d0cf Adapt API tests to allow for PDO mocks 2017-12-31 13:58:37 -05:00
J. King
ba0aeab7ec Make SQL statement type conversion use ValueInfo normalizer 
This sees the addition of a dateOutFormat parameter to ValueInfo::normalize(), as well as a general simplification of how parameter binding works.

Some value type-casting results are slightly different, but this simply makes SQL statement objects consistent with the rest of the system.
 2017-12-30 18:50:56 -05:00
J. King
bc9fcb975f Change "rebind" to "retype" to better reflect what actually happens 2017-12-30 17:04:21 -05:00
J. King
31aea0a06a PDO-SQLite type binding tests 
Db namespace is now back to full coverage
 2017-12-30 16:16:59 -05:00
J. King
bc9ffa0e17 Rewrite SQLite 3 type binding tests 2017-12-30 15:59:45 -05:00
J. King
39cad91b78 CS fixes 2017-12-22 11:51:58 -05:00
J. King
a5318d1b12 Part 2 2017-12-22 11:45:24 -05:00
J. King
095fe10aec Reorganize PDO tests into namespaces 2017-12-22 11:41:54 -05:00
J. King
59fee52074 Reorganize tests into namespaces 2017-12-21 22:47:19 -05:00
J. King
0785f832de CS fixes 2017-12-19 22:19:42 -05:00
J. King
4bada691e9 PDO tests and fixes; improves #72 2017-12-19 19:08:08 -05:00
J. King
ad6a09ffa1 Partially tested pdo_sqlite driver; improves #72 2017-12-19 17:15:05 -05:00
J. King
ef75b5e9ab SQLite driver tweaks 2017-12-19 12:11:49 -05:00
J. King
183718204d Grouped slow tests; improves #113 2017-12-16 20:03:04 -05:00
J. King
dd7d6e44b9 Further fixes for test timezone assumptions 2017-12-16 19:37:30 -05:00
J. King
3f65625090 Ensure tests do not rely in UTC default timezone 
Six tests failed if the default timezone was not UTC. These were all due to faulty expectations, however, not faulty output.
 2017-12-16 18:30:45 -05:00
J. King
415f7fd385 Fix feed timeout test; improves #113 2017-12-16 17:21:23 -05:00
J. King
3adfe8742f Reorganize test cases 2017-12-07 15:46:49 -05:00