1
1
Fork 0
mirror of https://code.mensbeam.com/MensBeam/Arsse.git synced 2024-12-24 09:32:40 +00:00
Commit graph

90 commits

Author SHA1 Message Date
J. King
8fc31cfc40 Rewrite various queries to work in PostgreSQL
This involved changes to the driver interface as well as the database
schemata. The most significantly altered queries were for article
selection and marking, which relied upon unusual features of SQLite.
Overall query efficiency should not be adversely affected (it may have
even imprved) in the common case, while very rare cases (not presently
triggered by any REST handlers) require more queries.

One notable benefit of these changes is that functions which query
articles can now have complete control over which columns are returned.
This has not, however, been implemented yet: symbolic column groups are
still used for now.

Note that PostgreSQL still fails many tests, but the test suite runs to
completion. Note also that one line of the Database class is not
covered; later changes will eventually make it easier to cover the line
in question.
2018-12-04 20:41:21 -05:00
J. King
527ecee393 Code coverage fixes 2018-11-29 13:56:15 -05:00
J. King
4a1c23ba45 Munge PostgreSQL queries instead of adding explicit casts
PDO does not adequately inform PostgreSQL of a parameter's type, so type
casts are required. Rather than adding these to each query manually, the
queries are instead processed to add type hints automatically.

Unfortunately the queries are processed rather naively; question-mark
characters in string constants, identifiers, regex patterns, or geometry
operators will break things spectacularly.
2018-11-29 13:45:37 -05:00
J. King
e68fcc0afa Manipulate only those sequences in the current PostgreSQL schema 2018-11-28 17:16:03 -05:00
J. King
4a2efd9987 Correct the state of PostgreSQL serial sequence during tests 2018-11-28 16:24:12 -05:00
J. King
dd4f22e04e Avoid use of reserved SQL word "user" 2018-11-28 14:21:36 -05:00
J. King
8dfedd30ef Test PostgreSQL schema upgrade
This was in fact buggy due to the schema version check causing an error
2018-11-28 10:46:23 -05:00
J. King
1414f8979c Fix savepoint handling and locking in PostgreSQL driver 2018-11-27 17:16:00 -05:00
J. King
8a49202036 Use common cleanup code for all database-related tests 2018-11-27 14:26:33 -05:00
J. King
dccd4caede Convert one database function test series (articles) to a common harness
Also revert the dropping of tables in the schema files. This was for the
convenience of tests, but the risk of data loss is too great
2018-11-24 23:18:17 -05:00
J. King
7340d65c0e Make data clearing in tests static 2018-11-23 10:01:17 -05:00
J. King
8c20411359 Align statement tests with other database driver tests 2018-11-22 23:18:20 -05:00
J. King
f22e53fdc9 Align result tests with driver tests 2018-11-22 19:55:54 -05:00
J. King
aa1b65b5d4 Take a different tack on shared database tests
Tests for different drivers will have their own files, but all derive
from a common prototype test series where applicable, similar to the
existing arrangement for database function tests. However, the prototype
will reside with other test cases rather than in the library path. The
database function test series will hopefully be moved as well in time.
2018-11-22 13:55:57 -05:00
J. King
736a8c9d0c Improved timeout handling for both SQlite and PostgreSQL 2018-11-22 13:30:13 -05:00
J. King
4e444fd86c Generic database interface creation in tests 2018-11-21 13:06:01 -05:00
J. King
c0c4810662 Nominally complete PostgreSQL driver
Connection error handling as well as uprade error handling still need
to be implemented.
2018-11-21 11:06:12 -05:00
J. King
84b4cb7465 Enable PostgreSQL statement testing
Tests involving binary data are skipped for now
2018-11-20 16:32:18 -05:00
J. King
b5733b070c Clean up statement tests
PostgreSQL tests are suppressed for now, but most pass.
2018-11-20 15:45:20 -05:00
J. King
976672de5b Test cleanup 2018-11-16 21:32:27 -05:00
J. King
edfae438fa Refine pg connection strings 2018-11-16 21:20:54 -05:00
J. King
c4ca9149a1 Move Statement tests 2018-11-09 15:01:46 -05:00
J. King
7e11019e83 Consolidate statement tests 2018-11-09 14:58:10 -05:00
J. King
ea6b4c951e Skip Result tests when necessary 2018-11-09 14:56:30 -05:00
J. King
a3dbb08da9 Remove obsolete test code 2018-11-08 16:29:46 -05:00
J. King
30d6f6db37 Consolidate Db result test series into single file 2018-11-08 14:50:58 -05:00
J. King
2dd1b45d3e Cover the Query class with database tests for now 2018-11-06 12:51:34 -05:00
J. King
d40243a84c Clean up configuration setting in tests 2018-11-04 09:16:34 -05:00
J. King
f64f0c6a22 Whitespace cleanup 2018-10-26 14:58:04 -04:00
J. King
ba0aeab7ec Make SQL statement type conversion use ValueInfo normalizer
This sees the addition of a dateOutFormat parameter to ValueInfo::normalize(), as well as a general simplification of how parameter binding works.

Some value type-casting results are slightly different, but this simply makes SQL statement objects consistent with the rest of the system.
2017-12-30 18:50:56 -05:00
J. King
bc9fcb975f Change "rebind" to "retype" to better reflect what actually happens 2017-12-30 17:04:21 -05:00
J. King
31aea0a06a PDO-SQLite type binding tests
Db namespace is now back to full coverage
2017-12-30 16:16:59 -05:00
J. King
bc9ffa0e17 Rewrite SQLite 3 type binding tests 2017-12-30 15:59:45 -05:00
J. King
39cad91b78 CS fixes 2017-12-22 11:51:58 -05:00
J. King
a5318d1b12 Part 2 2017-12-22 11:45:24 -05:00
J. King
095fe10aec Reorganize PDO tests into namespaces 2017-12-22 11:41:54 -05:00
J. King
4bada691e9 PDO tests and fixes; improves #72 2017-12-19 19:08:08 -05:00
J. King
ad6a09ffa1 Partially tested pdo_sqlite driver; improves #72 2017-12-19 17:15:05 -05:00
J. King
ef75b5e9ab SQLite driver tweaks 2017-12-19 12:11:49 -05:00
J. King
3adfe8742f Reorganize test cases 2017-12-07 15:46:49 -05:00