mirror/Arsse
1
1
Fork 0
mirror of https://code.mensbeam.com/MensBeam/Arsse.git synced 2024-12-22 21:22:40 +00:00
Code Issues Activity
852 commits 11 branches 28 tags 4.1 MiB
Commit graph

520 commits

Author SHA1 Message Date
J. King
e2cba68c1b Clarify various SQL queries 2019-03-05 19:25:46 -05:00
J. King
4945f8baa3 Clarify various SQL queries 2019-03-05 19:22:01 -05:00
J. King
6000d80b7b Work around various SQLite-related problems 
- WAL mode was not getting set properly
- Queries using the PDO driver could fail because PDO sucks
 2019-03-04 11:08:56 -05:00
J. King
ed22090e49 Work around various SQLite-related problems 
- WAL mode was not getting set properly
- Queries using the PDO driver could fail because PDO sucks
 2019-03-04 11:05:46 -05:00
J. King
fb1bdbfb37 Database schema for subscription tags 2019-03-03 12:10:18 -05:00
J. King
5efef2c2d0 Console command to refresh all feeds once; fixes #147 2019-03-02 14:59:44 -05:00
J. King
44366f48bf Remove arbitrary search term limits; fixes #150 2019-03-02 13:53:43 -05:00
J. King
21fdd66d37 Work around limit to SQL parameter placeholders for IN() clauses 
Improves #150

LIKE-based matches also need to be similarly conservative
 2019-03-01 22:36:25 -05:00
J. King
6857e8ec1b Merge branch 'search' 2019-03-01 12:26:08 -05:00
J. King
837f3c6dd6 Simplify SQL type handling 
This is done in anticipation of dealing with SQL types in
places other than statements
 2019-03-01 12:17:33 -05:00
J. King
3b8461b1ca Add searching to TTRSS handler 2019-02-28 16:22:04 -05:00
J. King
85307bc90a Add parser for TTRSS search strings 2019-02-28 15:31:33 -05:00
J. King
95de375e0b Handle folder and label exclusion 
Consequently the way label data are retrieved was completely overhauled
 2019-02-27 10:48:11 -05:00
J. King
1e7724ec80 Filter out duplicates in set context options 2019-02-26 12:54:27 -05:00
J. King
677e33e518 Add text search exclusions 2019-02-26 11:39:19 -05:00
J. King
89f25d7b91 Fix coverage a little 2019-02-26 11:12:40 -05:00
J. King
0dc82f64d5 Allow ranges in exclusion contexts 2019-02-26 11:11:42 -05:00
J. King
70443a5264 Make parent re-association on context clone more restrictive 2019-02-25 23:59:48 -05:00
J. King
18d52ea402 Make exclusion contexts return their parent on change 2019-02-25 23:37:14 -05:00
J. King
b950ac066f Restrict options in not-context and hopefully make it easier to use 2019-02-25 22:41:12 -05:00
J. King
14c02d56ac Implement new context options other than not(). 
Context handling has also been re-organized to simplify later
implementation of the not() option
 2019-02-25 16:26:38 -05:00
J. King
f4a74eec5d Add all the other context options allowed by the TTRSS search syntax 2019-02-25 10:46:43 -05:00
J. King
2df7c25b66 Add ability to search note text 2019-02-23 20:14:52 -05:00
J. King
bc3182a961 Basic substring searching 2019-02-22 18:50:39 -05:00
J. King
570a9b171c Revert fulltext detection in driver 2019-02-22 18:49:57 -05:00
J. King
ace94e3ef8 Fix context, and context tests 2019-02-22 12:34:06 -05:00
J. King
f9fde23708 Context changes to support basic text searching 2019-02-22 11:13:42 -05:00
J. King
ad8057a40b Driver changes to support basic text searching 2019-02-22 11:13:13 -05:00
J. King
908e1fa310 API documentation for database driver interface 2019-02-21 15:43:19 -05:00
J. King
b55d0b374f API documentation for database driver interface 2019-02-21 15:10:32 -05:00
J. King
17f3a2f059 Start on an API overview for the Database class 2019-02-13 12:37:41 -05:00
J. King
b0d5458367 Clarify some prospective protocols 2019-02-04 13:18:33 -05:00
J. King
49cefaf5c8 Complete API documentation for the Database class 2019-02-04 13:05:48 -05:00
J. King
d3a385beef Partial API documentation for the Database class 2019-02-03 12:25:07 -05:00
J. King
b1282b6f6a Upgrade to PHP 7.1 and PHPUnit 7. 2019-01-25 22:07:37 -05:00
J. King
f5c5d49d97 Document SQL timeout changes 2019-01-24 11:40:25 -05:00
J. King
500851f161 Style fixes 2019-01-23 16:34:54 -05:00
J. King
91b6fdc696 Update changelog; bump version 2019-01-23 16:32:48 -05:00
J. King
8ea1df920a Unify SQL timeouts 
- Exec and lock timeouts now apply to MySQL
- Lock timeout now applies to PostgreSQL
- SQLite now uses a generic lock timeout setting which applies to all
 2019-01-23 16:31:54 -05:00
J. King
970731073d Fetch timeout should be a float, not an integer 2019-01-23 09:37:41 -05:00
J. King
9120d3b3e3 Correctly escape shell command in subprocesds service driver 2019-01-23 09:32:44 -05:00
J. King
a5049ac646 Remove reference to PicoFeed in the User-Agent string 
PicoFeed is dead, so there's no point.
 2019-01-23 09:21:35 -05:00
J. King
37131d3775 Remove non-functional curl service driver for now 
Its requiring extensive configuration to function makes me disinclined
to revive it, though it may nevertheless happen.
 2019-01-23 09:19:26 -05:00
J. King
05aadfe7c7 Use correct SQLite chema change procedure; version bump 2019-01-21 10:40:39 -05:00
J. King
5335d331f7 Fix configuration exporting 2019-01-21 09:55:25 -05:00
J. King
5cd84c4ab4 Validate configuration parameters on import, and other changes 
- Each parameter is checked for type and normalized
- Interval strings are converted to DateInterval objects
- Timeouts can be specified as interval strings
- Most intervals can be null to signify infinity
- Driver classes are checked that they implement the correct interface
- Short driver names may be used, and are used by default
- Helpful errors messages are printed in case of erroneous configuration

Exporting is currently broken; this will be fixed in an upcoming commit
 2019-01-20 22:40:49 -05:00
J. King
b0643de21c Add handling of DateInterval objects to ValueInfo 2019-01-17 16:29:42 -05:00
J. King
4670dfc849 Handle connection errors 2019-01-15 10:51:55 -05:00
J. King
e92bda5373 Various changes: 
- Fix handling of binary data and long strings
- Simplify handling of socket connections
- Fix coverage
 2019-01-15 08:58:11 -05:00
J. King
5d61ab0a57 Fixes for MySQL native interface 
Three test failures remain, but these are minor and will be resolved
soon. Handling of binary data is also broken, but given that this works
fine with the PDO driver, there is presumably some correct method.
 2019-01-13 23:17:19 -05:00
J. King
81acba90dc Use strict equality when comparing strings 2019-01-11 10:38:06 -05:00
J. King
c4a41255b0 Experimental native MySQL driver 
No testing has been performed yet, but changes are extensive enough to
warrant a commit. Of particular note:

- SQL states are enumerated in a separate trait to reduce duplication
- PDOStatement is now an abstract class to avoid duplication of
engine-specific error handling
- Error handling has been cleaned up somewhat
 2019-01-10 19:01:32 -05:00
J. King
206cca35a9 Test tweaks 2018-12-21 17:51:49 -05:00
J. King
5a133b795a Correctly munge MySQL queries 2018-12-21 17:37:22 -05:00
J. King
b4de56a64e Work around MySQL silliness with same-table foreign keys 2018-12-21 17:02:34 -05:00
J. King
f0d30c2eee Make munging of queries a generic feature 2018-12-21 12:35:10 -05:00
J. King
24df564045 Mostly successful MySQL database function tests 
Two failures remain, at least one requiring query munging.
 2018-12-21 10:14:26 -05:00
J. King
de07352fd0 Syntactic adjustments for MySQL 
- "key", "read", and "rename" are reserved words
- CTEs in INSERTs must precede SELECT
- Empty sets are represented only by explicit null
 2018-12-20 21:23:06 -05:00
J. King
393b4e95ad Adjustments for MySQL 8 
The prototype had been tested against MariaDB
 2018-12-20 20:50:56 -05:00
J. King
4ef36643a4 Proof-of-concept PDO MySQL driver 
- Configuration options were added
- Non-transactional locking was added to the savepoint handlers
- Tests were adjusted for MySQL's reserved words
 2018-12-20 18:06:28 -05:00
J. King
50f92625ef Use PosgreSQL's existing general Unicode collation 
All collations appear to be case-insensitive
 2018-12-14 09:18:56 -05:00
J. King
2bebdd44cf Implementation of native PostgreSQL interface 
Changes to the Database class were required to avoid outputting booleans
 2018-12-13 19:47:51 -05:00
J. King
161f5f08f6 Proactively support SQLite 3.25 2018-12-12 12:21:28 -05:00
J. King
28f803dd28 Handle PostgreSQL connection errors 2018-12-12 11:15:07 -05:00
J. King
0f48ce6f37 Use a Unicode collation for SQLite 2018-12-11 14:14:32 -05:00
J. King
35d46d2913 Use persistent connections with PostgreSQL 2018-12-10 12:28:43 -05:00
J. King
f6966659a9 Use smarter coverage executer; properly suppress stderr during CLI tests 2018-12-07 20:25:48 -05:00
J. King
0513b606c2 Merge master 2018-12-07 19:21:44 -05:00
J. King
089f666de6 Fix PDO insert ID errors in PHP 7.1 2018-12-06 17:46:00 -05:00
J. King
cf896121b2 Style fixes 2018-12-05 17:28:11 -05:00
J. King
51755a2ce6 Retire article field groups 2018-12-05 16:55:14 -05:00
J. King
15301cd7dc Fix cleanup tests in PostgreSQL 2018-12-05 11:05:01 -05:00
J. King
258be1d54e Fix most PostgreSQL test failures 
Reasons for failures included an unhandled error code, erroneous sorting
assumptions, and a broken computation of the next insert ID in tests

Five failures remain.
 2018-12-05 09:05:43 -05:00
J. King
8fc31cfc40 Rewrite various queries to work in PostgreSQL 
This involved changes to the driver interface as well as the database
schemata. The most significantly altered queries were for article
selection and marking, which relied upon unusual features of SQLite.
Overall query efficiency should not be adversely affected (it may have
even imprved) in the common case, while very rare cases (not presently
triggered by any REST handlers) require more queries.

One notable benefit of these changes is that functions which query
articles can now have complete control over which columns are returned.
This has not, however, been implemented yet: symbolic column groups are
still used for now.

Note that PostgreSQL still fails many tests, but the test suite runs to
completion. Note also that one line of the Database class is not
covered; later changes will eventually make it easier to cover the line
in question.
 2018-12-04 20:41:21 -05:00
J. King
5c5a5a4886 Appease PostgreSQL's max() aggregate 2018-11-29 14:36:34 -05:00
J. King
527ecee393 Code coverage fixes 2018-11-29 13:56:15 -05:00
J. King
4a1c23ba45 Munge PostgreSQL queries instead of adding explicit casts 
PDO does not adequately inform PostgreSQL of a parameter's type, so type
casts are required. Rather than adding these to each query manually, the
queries are instead processed to add type hints automatically.

Unfortunately the queries are processed rather naively; question-mark
characters in string constants, identifiers, regex patterns, or geometry
operators will break things spectacularly.
 2018-11-29 13:45:37 -05:00
J. King
4c8d8f1a52 Provide PostgreSQL with an empty-set query for IN() clauses 
Also satisfy PostgreSQL with some explicit casts
 2018-11-28 17:18:33 -05:00
J. King
dd4f22e04e Avoid use of reserved SQL word "user" 2018-11-28 14:21:36 -05:00
J. King
8dfedd30ef Test PostgreSQL schema upgrade 
This was in fact buggy due to the schema version check causing an error
 2018-11-28 10:46:23 -05:00
J. King
93af381436 Test setting of schema name 2018-11-27 17:39:39 -05:00
J. King
1414f8979c Fix savepoint handling and locking in PostgreSQL driver 2018-11-27 17:16:00 -05:00
J. King
736a8c9d0c Improved timeout handling for both SQlite and PostgreSQL 2018-11-22 13:30:13 -05:00
J. King
c0c4810662 Nominally complete PostgreSQL driver 
Connection error handling as well as uprade error handling still need
to be implemented.
 2018-11-21 11:06:12 -05:00
J. King
84b4cb7465 Enable PostgreSQL statement testing 
Tests involving binary data are skipped for now
 2018-11-20 16:32:18 -05:00
J. King
d52af6db5a PostgreSQL fixes 
Errors were not correctly throwing exceptions

For the sake of SQLite compatibility booleans should be bound as
integers in PDO
 2018-11-20 15:48:03 -05:00
J. King
e2b6cb8360 Remove PicoFeed-related FIXMEs 
PicoFeed will never be fixed, so they are not helpful
 2018-11-20 15:46:22 -05:00
J. King
b5733b070c Clean up statement tests 
PostgreSQL tests are suppressed for now, but most pass.
 2018-11-20 15:45:20 -05:00
J. King
e30d82fbaa Correct signature 2018-11-16 21:35:05 -05:00
J. King
edfae438fa Refine pg connection strings 2018-11-16 21:20:54 -05:00
J. King
796315c00c Basic stub of PDO-base PostgreSQL driver 2018-11-10 00:02:38 -05:00
J. King
3b3b810f10 Replicate some unspecified NCNv1 behaviour, and document the rest 
See #139 for list

Closes #139
Closes #140
Closes #141
 2018-11-07 13:01:46 -05:00
J. King
1dcbb56077 Changelog and documentation updates 2018-11-07 10:24:35 -05:00
J. King
63ae6fb703 Merge remote-tracking branch 'remotes/origin/user-rewrite' 2018-11-06 16:36:50 -05:00
J. King
3a4100576a Merge remote-tracking branch 'remotes/origin/cli-overhaul' 2018-11-06 16:36:35 -05:00
J. King
39134f5f7e Rest of CLI tests 2018-11-06 16:35:33 -05:00
J. King
efac62f0e4 Add missing return type hints where possible 2018-11-06 12:50:26 -05:00
J. King
9e6f0460c2 Ensure the Lang class always exists when throwing exceptions 2018-11-06 12:48:31 -05:00
J. King
ba8e208d79 Partial CLI tests 2018-11-06 12:32:28 -05:00
J. King
1a8acdf03f Fix early exceptions 2018-11-06 09:04:51 -05:00
J. King
9428d7468a Add more user management functionality to the CLI 2018-11-05 09:08:50 -05:00
J. King
a8cc9a4780 Tests for internal user driver; closes #50 2018-11-04 12:06:30 -05:00
J. King
5f775bef7a Appease phpdbg coverage bug 2018-11-03 13:49:02 -04:00
J. King
1ac85df46b Last set of tests for User class 2018-11-03 13:26:22 -04:00
J. King
ffa7bd5a5d Fix error in previous commit 2018-11-02 12:01:03 -04:00
J. King
931fe3b585 Move password generation to the User class 
This allows user drivers which wish to generate their own passwords to
do so, and those which do not to defer to the built-in generator
 2018-11-02 11:52:55 -04:00
J. King
31cdf313a4 Add missing return type hints where possible 2018-11-02 11:47:10 -04:00
J. King
898533bde5 More simplification 
Authentication is now used as the primary point of synchronization
between the internal database and any external database
 2018-11-02 10:01:49 -04:00
J. King
40d679844b Ensure the Lang class always exists when throwing exceptions 2018-10-31 14:32:11 -04:00
J. King
27edcddc9b Simplify NCNv1 userStatus call 2018-10-28 13:59:09 -04:00
J. King
057d72c816 Remove the distinction between internal and external user functionality 2018-10-28 13:50:57 -04:00
J. King
11747c93fd Strip out unused user management functionality 
Tests have been removed as well; new tests are forthcoming
 2018-10-28 10:59:17 -04:00
J. King
0be9dcb5a8 Update dependencies 2018-10-26 16:27:18 -04:00
J. King
f64f0c6a22 Whitespace cleanup 2018-10-26 14:58:04 -04:00
J. King
1aa556cf12 Add HTTP authentication support to TTRSS; fixes #133 
Also bump version to 0.4.0
 2018-10-26 14:40:20 -04:00
J. King
edbfb12d17 Improve coverage slightly 
Improves #66
 2018-08-17 08:35:13 -04:00
J. King
e4d64424c7 Make new bugfix release 2018-07-22 12:30:44 -04:00
J. King
a92bad1bc8 Correctly load configuration 2018-06-18 10:09:43 -04:00
J. King
c7c5f48066 Fix notice 2018-01-24 23:25:54 -05:00
J. King
cbc9491f75 CS fixes and version bump 2018-01-12 09:48:33 -05:00
J. King
34b508171b Merge CORS branch 2018-01-12 09:41:13 -05:00
J. King
1a4989e1e0 Merge PDO branch 2018-01-12 09:28:58 -05:00
J. King
aa57227097 Use PSR-7 for authentication; fixes #53 2018-01-11 15:48:29 -05:00
J. King
90dfeb727a Implement CORS; fixes #126 2018-01-09 12:31:40 -05:00
J. King
0ec0a5b085 Ensure the request method is always uppercased 2018-01-08 17:11:38 -05:00
J. King
4b53c5e8b3 Tests and fixes for REST class; fixes #53; improves #66 2018-01-07 12:59:10 -05:00
J. King
3fa2d38f31 Initial rewrite of REST class; needs more testing, but should be functional 
- improves #53
- improves #66
 2018-01-06 12:02:45 -05:00
J. King
890f9b07d4 Replace Resquest objects with PSR-7 request messages; improves #53 2018-01-04 23:08:53 -05:00
J. King
9ad0b47201 Add Target class to manipulate request traget URL parts 
The query part is not parsed for now because PSR-7 request objects/PHP take care of that parsing for us.
 2018-01-04 14:06:45 -05:00
J. King
9eadd602bd Replace Response objects with PSR-7 response messages; improves #53 
While the test suite passes, this commit yields a broken server: replacing ad hoc request objectss with PSR-7 ones is still required, as is emission of PSR-7 responses. Both will come in subsequent commits, with tests

Diactoros was chosen specifically because it includes facilities for emitting responses, something which is awkward to test. The end of this refactoring should see both the Response and Request classes disappear, and the general REST class fully covered (as well as any speculative additions to AbstractHanlder).
 2018-01-03 23:13:08 -05:00
J. King
27caf147df Changes to Date helper class 
- Changed 'transform' method to use ValueInfo throughout. This fixes a number of obscure bugs
- Changed the 'add' and 'sub' methods to default to "now" rather than null. This means null passes through rather than being interpreted as the current time, to be consistent with other date tools
- Also changed the 'add' and 'sub' methods so that they operate correctly with invalid date strings
- Added tests for the class; improves #66
- Modified TTRSS tests because the "iso8601" format string in ValueInfo is different from Date's older format
 2018-01-02 16:53:38 -05:00
J. King
89bfc23d32 Standardize date normalization to immutables 
Also move date formats to the ValueInfo class

Standardizing on immutables avoids any possible ambiguity in the API of the resultant value, as well as any ambiguity as to whether a DateTime output instance is the same instance or a clone (they had been clones)
 2018-01-02 16:27:58 -05:00
J. King
87faededc6 Backport PDO changes to ValueInfo 2018-01-02 10:29:24 -05:00
J. King
ddf55e0665 Change session lifetimes to more closely match TTRSS 
At least some clients seem to expect the default timeout of one day.
 2018-01-01 12:31:42 -05:00
J. King
77793f95cb Controller fixes for PDO databases; fixes #72 2017-12-31 17:24:40 -05:00
J. King
ba0aeab7ec Make SQL statement type conversion use ValueInfo normalizer 
This sees the addition of a dateOutFormat parameter to ValueInfo::normalize(), as well as a general simplification of how parameter binding works.

Some value type-casting results are slightly different, but this simply makes SQL statement objects consistent with the rest of the system.
 2017-12-30 18:50:56 -05:00
J. King
bc9fcb975f Change "rebind" to "retype" to better reflect what actually happens 2017-12-30 17:04:21 -05:00
J. King
bc9ffa0e17 Rewrite SQLite 3 type binding tests 2017-12-30 15:59:45 -05:00
J. King
39cad91b78 CS fixes 2017-12-22 11:51:58 -05:00
J. King
4bada691e9 PDO tests and fixes; improves #72 2017-12-19 19:08:08 -05:00
J. King
ad6a09ffa1 Partially tested pdo_sqlite driver; improves #72 2017-12-19 17:15:05 -05:00
J. King
ef75b5e9ab SQLite driver tweaks 2017-12-19 12:11:49 -05:00
J. King
7ca0f4e877 Make the SQLite3 driver more generic 
The changes in this commit should make it more practical to:

- Allow the driver to decide for itself whether to try creating a PDO object if its own requirements are not met
- Have any driver use a generic schema update procedure
- Use the same constructor for native and PDO SQLite
 2017-12-18 18:29:32 -05:00
J. King
73c8583744 Remove reliance on xdebug; fixes #113 
Code coverage information is now gathered via phpdbg (a separate executable) by if available rather than xdebug, as the latter is hard to turn on and off.

A "test:quick" task has also been added to Robo, which excludes 31 tests which together account for almost two thirds of the test run time. This should pave the way for testing to be added as a commit hook for Git.
 2017-12-17 10:27:34 -05:00
Dustin Wilson
b8ed7c6bf8 Added missing static keyword to Misc\ValueInfo::normalize() 2017-12-10 11:16:06 -06:00
J. King
f100cab558 Version bump 2017-12-07 18:24:35 -05:00
J. King
44ae0ba29b Collate synthetic subscription title column; fixes #127 2017-12-07 18:17:16 -05:00
J. King
0b3b3cb49c Use SQLite nocase collation; improves #127 2017-12-07 18:05:34 -05:00
J. King
79f9808f1f CS fixes 2017-12-07 15:18:25 -05:00
J. King
8d0dd15c8a Remove use of SQLite IS operator; fixes #120 2017-12-06 22:26:06 -05:00