From cfef75ccbaaa238577302e4f7e2bcf90b09780e8 Mon Sep 17 00:00:00 2001 From: "J. King" Date: Tue, 6 Aug 2019 09:58:30 -0400 Subject: [PATCH] Don't update the feed URL when fetching This can result in some unpredictable constraint violations --- CHANGELOG | 1 + lib/Database.php | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index c587d3d6..bd999a6e 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -3,6 +3,7 @@ Version 0.8.1 (2019-??-??) Bug fixes: - Don't crash updating feeds cached solely via ETag +- Don't update feed URLs when fetching Version 0.8.0 (2019-07-26) ========================== diff --git a/lib/Database.php b/lib/Database.php index 7c61aff2..875a36b6 100644 --- a/lib/Database.php +++ b/lib/Database.php @@ -1152,8 +1152,7 @@ class Database { } // lastly update the feed database itself with updated information. $this->db->prepare( - "UPDATE arsse_feeds SET url = ?, title = ?, favicon = ?, source = ?, updated = CURRENT_TIMESTAMP, modified = ?, etag = ?, err_count = 0, err_msg = '', next_fetch = ?, size = ? WHERE id = ?", - 'str', + "UPDATE arsse_feeds SET title = ?, favicon = ?, source = ?, updated = CURRENT_TIMESTAMP, modified = ?, etag = ?, err_count = 0, err_msg = '', next_fetch = ?, size = ? WHERE id = ?", 'str', 'str', 'str', @@ -1163,7 +1162,6 @@ class Database { 'int', 'int' )->run( - $feed->data->feedUrl, $feed->data->title, $feed->favicon, $feed->data->siteUrl,