From b306f0fc2997513a9c83a71ca78ca991fd92598d Mon Sep 17 00:00:00 2001 From: "J. King" Date: Fri, 27 Dec 2024 09:45:22 -0500 Subject: [PATCH] Crash was related to xdebug --- tests/cases/Db/TestTransaction.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/cases/Db/TestTransaction.php b/tests/cases/Db/TestTransaction.php index 58fc3814..72d6ec55 100644 --- a/tests/cases/Db/TestTransaction.php +++ b/tests/cases/Db/TestTransaction.php @@ -54,15 +54,12 @@ class TestTransaction extends \JKingWeb\Arsse\Test\AbstractTest { } public function testIgnoreRollbackErrors(): void { - // FIXME: This test segfaults when both transactions are checked. - // It appears to be a wonky interaction with Phake, and not a problem - // with the actual code. \Phake::when($this->drv)->savepointUndo->thenThrow(new Exception("savepointStale")); $tr1 = new Transaction($this->drv); - //$tr2 = new Transaction($this->drv); + $tr2 = new Transaction($this->drv); unset($tr1); // no exception should bubble up - //unset($tr2); // no exception should bubble up + unset($tr2); // no exception should bubble up \Phake::verify($this->drv)->savepointUndo(1); - //\Phake::verify($this->drv)->savepointUndo(2); + \Phake::verify($this->drv)->savepointUndo(2); } }