Style fixes

CHANGELOG

@@ -1,8 +1,10 @@
-Version 0.9.3 (2021-??-??)
+Version 0.10.0 (2021-??-??)
 ==========================
 
 New features:
 - Complete UNIX manual page
+- Support for running service as a forking daemon
+- Respond to TERM and HUP signals when possible
 
 Version 0.9.2 (2021-05-25)
 ==========================

composer.json

@@ -34,6 +34,9 @@
     "require-dev": {
         "bamarni/composer-bin-plugin": "*"
     },
+    "suggest": {
+        "ext-pcntl": "To respond to signals, particular to reload configuration via SIGHUP"
+    },
     "config": {
         "platform": {
             "php": "7.1.33"

lib/Service.php

@@ -44,10 +44,12 @@ class Service {
             if ($this->loop) {
                 do {
                     sleep((int) max(0, $t->getTimestamp() - time()));
+                    if (function_exists("pcntl_signal_dispatch")) {
                         pcntl_signal_dispatch();
                         if ($this->reload) {
                             $this->reload();
                         }
+                    }
                 } while ($this->loop && $t->getTimestamp() > time());
             }
             // @codeCoverageIgnoreEnd

tests/cases/ImportExport/TestOPML.php

@@ -11,7 +11,6 @@ use JKingWeb\Arsse\Database;
 use JKingWeb\Arsse\Test\Result;
 use JKingWeb\Arsse\ImportExport\OPML;
 use JKingWeb\Arsse\ImportExport\Exception;
-use ReflectionMethod;
 
 /** @covers \JKingWeb\Arsse\ImportExport\OPML<extended> */
 class TestOPML extends \JKingWeb\Arsse\Test\AbstractTest {

tests/cases/Misc/TestValueInfo.php

@@ -12,7 +12,6 @@ use JKingWeb\Arsse\Test\Result;
 
 /** @covers \JKingWeb\Arsse\Misc\ValueInfo */
 class TestValueInfo extends \JKingWeb\Arsse\Test\AbstractTest {
-
     public function testGetIntegerInfo(): void {
         $tests = [
             [null,          I::NULL],

tests/cases/REST/Fever/TestAPI.php

@@ -15,7 +15,6 @@ use JKingWeb\Arsse\Db\ExceptionInput;
 use JKingWeb\Arsse\Db\Transaction;
 use JKingWeb\Arsse\REST\Fever\API;
 use Psr\Http\Message\ResponseInterface;
-use Laminas\Diactoros\ServerRequest;
 use Laminas\Diactoros\Response\JsonResponse;
 use Laminas\Diactoros\Response\XmlResponse;
 use Laminas\Diactoros\Response\EmptyResponse;

tests/cases/REST/TestREST.php

@@ -306,7 +306,7 @@ class TestREST extends \JKingWeb\Arsse\Test\AbstractTest {
         if ($called) {
             $rMock->authenticateRequest->called();
             $hMock->dispatch->once()->called();
-            $in = $hMock->dispatch->firstCall()->argument();;
+            $in = $hMock->dispatch->firstCall()->argument();
             $this->assertSame($method, $in->getMethod());
             $this->assertSame($target, $in->getRequestTarget());
         } else {

tests/cases/REST/TinyTinyRSS/TestAPI.php

@@ -1356,7 +1356,6 @@ LONG_STRING;
         ];
     }
 
-    
     /** @dataProvider provideArticleChanges */
     public function testChangeArticles(array $in, ResponseInterface $exp): void {
         $in = array_merge(['op' => "updateArticle", 'sid' => "PriestsOfSyrinx"], $in);

tests/cases/Service/TestService.php

@@ -23,7 +23,6 @@ class TestService extends \JKingWeb\Arsse\Test\AbstractTest {
         $this->srv = new Service();
     }
 
-
     public function testCheckIn(): void {
         $now = time();
         $this->srv->checkIn();

tests/lib/AbstractTest.php

@@ -37,7 +37,6 @@ abstract class AbstractTest extends \PHPUnit\Framework\TestCase {
     protected $dbMock;
     protected $userMock;
 
-
     public function setUp(): void {
         self::clearData();
         // create the object factory as a mock
@@ -155,7 +154,6 @@ abstract class AbstractTest extends \PHPUnit\Framework\TestCase {
         } else {
             parent::assertFileNotExists($filename, $message);
         }
-        
     }
 
     public function assertException($msg = "", string $prefix = "", string $type = "Exception"): void {