mirror/Arsse
1
1
Fork 0
mirror of https://code.mensbeam.com/MensBeam/Arsse.git synced 2024-12-23 17:12:41 +00:00
Code Issues Activity
Arsse/lib/Db/PostgreSQL/PDOStatement.php

20 lines
611 B
PHP
Raw Normal View History

Munge PostgreSQL queries instead of adding explicit casts PDO does not adequately inform PostgreSQL of a parameter's type, so type casts are required. Rather than adding these to each query manually, the queries are instead processed to add type hints automatically. Unfortunately the queries are processed rather naively; question-mark characters in string constants, identifiers, regex patterns, or geometry operators will break things spectacularly.
2018-11-29 18:45:37 +00:00
<?php
/** @license MIT
* Copyright 2017 J. King, Dustin Wilson et al.
* See LICENSE and AUTHORS files for details */
declare(strict_types=1);
namespace JKingWeb\Arsse\Db\PostgreSQL;
Experimental native MySQL driver No testing has been performed yet, but changes are extensive enough to warrant a commit. Of particular note: - SQL states are enumerated in a separate trait to reduce duplication - PDOStatement is now an abstract class to avoid duplication of engine-specific error handling - Error handling has been cleaned up somewhat
2019-01-11 00:01:32 +00:00
class PDOStatement extends \JKingWeb\Arsse\Db\PDOStatement {
Make munging of queries a generic feature
2018-12-21 17:35:10 +00:00
public static function mungeQuery(string $query, array $types, ...$extraData): string {
return Statement::mungeQuery($query, $types, false);
Munge PostgreSQL queries instead of adding explicit casts PDO does not adequately inform PostgreSQL of a parameter's type, so type casts are required. Rather than adding these to each query manually, the queries are instead processed to add type hints automatically. Unfortunately the queries are processed rather naively; question-mark characters in string constants, identifiers, regex patterns, or geometry operators will break things spectacularly.
2018-11-29 18:45:37 +00:00
}
Experimental native MySQL driver No testing has been performed yet, but changes are extensive enough to warrant a commit. Of particular note: - SQL states are enumerated in a separate trait to reduce duplication - PDOStatement is now an abstract class to avoid duplication of engine-specific error handling - Error handling has been cleaned up somewhat
2019-01-11 00:01:32 +00:00
Various changes: - Fix handling of binary data and long strings - Simplify handling of socket connections - Fix coverage
2019-01-15 13:58:11 +00:00
/** @codeCoverageIgnore */
Experimental native MySQL driver No testing has been performed yet, but changes are extensive enough to warrant a commit. Of particular note: - SQL states are enumerated in a separate trait to reduce duplication - PDOStatement is now an abstract class to avoid duplication of engine-specific error handling - Error handling has been cleaned up somewhat
2019-01-11 00:01:32 +00:00
public static function buildEngineException($code, string $msg): array {
// PostgreSQL uses SQLSTATE exclusively, so this is not used
return [];
}
Munge PostgreSQL queries instead of adding explicit casts PDO does not adequately inform PostgreSQL of a parameter's type, so type casts are required. Rather than adding these to each query manually, the queries are instead processed to add type hints automatically. Unfortunately the queries are processed rather naively; question-mark characters in string constants, identifiers, regex patterns, or geometry operators will break things spectacularly.
2018-11-29 18:45:37 +00:00
}
Copy permalink