actions/setup-node
1
0
Fork 0
mirror of https://github.com/actions/setup-node synced 2025-04-03 15:45:52 +00:00
Code Issues Activity

improvements

Browse source
This commit is contained in:
Aparna Jyothi 2025-03-04 16:31:53 +05:30
parent 8b9906e7bf
commit f338189333
4 changed files with 7 additions and 17 deletions
__tests__
main.test.ts
action.yml
dist/setup
index.js
src/distributions/official_builds
official_builds.ts

1
__tests__/main.test.ts
View file

@ -305,7 +305,6 @@ describe('main tests', () => {
// Arrange // Arrange
inputs['mirror-url'] = ' '; inputs['mirror-url'] = ' ';
// Mock log and setFailed
const logSpy = jest.spyOn(console, 'log').mockImplementation(() => {}); // Mock the log function const logSpy = jest.spyOn(console, 'log').mockImplementation(() => {}); // Mock the log function
// Act & Assert // Act & Assert

2
action.yml
View file

@ -17,7 +17,7 @@ inputs:
registry-url: registry-url:
description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.' description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.'
mirror-url: mirror-url:
description: 'Custom mirror URL to download Node.js from (optional)' description: 'Custom mirror URL to download Node.js'
required: false required: false
scope: scope:
description: 'Optional scope for authenticating against scoped registries. Will fall back to the repository owner when using the GitHub Packages registry (https://npm.pkg.github.com/).' description: 'Optional scope for authenticating against scoped registries. Will fall back to the repository owner when using the GitHub Packages registry (https://npm.pkg.github.com/).'

12
dist/setup/index.js vendored
View file

@ -100510,17 +100510,14 @@ class OfficialBuilds extends base_distribution_1.default {
} }
setupNodeJs() { setupNodeJs() {
return __awaiter(this, void 0, void 0, function* () { return __awaiter(this, void 0, void 0, function* () {
var _a, _b; var _a;
if (this.nodeInfo.mirrorURL) { if (this.nodeInfo.mirrorURL) {
let downloadPath = '';
try { try {
core.info(`Attempting to download using mirror URL...`); core.info(`Attempting to download using mirror URL...`);
downloadPath = yield this.downloadFromMirrorURL(); // Attempt to download from the mirror yield this.downloadFromMirrorURL(); // Attempt to download from the mirror
} }
catch (err) { catch (err) {
core.setFailed(err.message); core.setFailed(err.message);
core.setFailed('Download failed');
core.debug((_a = err.stack) !== null && _a !== void 0 ? _a : 'empty stack');
} }
} }
else { else {
@ -100581,7 +100578,7 @@ class OfficialBuilds extends base_distribution_1.default {
else { else {
core.info(err.message); core.info(err.message);
} }
core.debug((_b = err.stack) !== null && _b !== void 0 ? _b : 'empty stack'); core.debug((_a = err.stack) !== null && _a !== void 0 ? _a : 'empty stack');
core.info('Falling back to download directly from Node'); core.info('Falling back to download directly from Node');
} }
if (!toolPath) { if (!toolPath) {
@ -100719,11 +100716,10 @@ class OfficialBuilds extends base_distribution_1.default {
catch (error) { catch (error) {
if (error instanceof tc.HTTPError && error.httpStatusCode === 404) { if (error instanceof tc.HTTPError && error.httpStatusCode === 404) {
core.setFailed(`Node version ${this.nodeInfo.versionSpec} for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} was found but failed to download. ` + core.setFailed(`Node version ${this.nodeInfo.versionSpec} for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} was found but failed to download. ` +
'This usually happens when downloadable binaries are not fully updated at https://nodejs.org/. ' + 'This usually happens when downloadable binaries are not fully updated in the provided mirror-url' +
'To resolve this issue you may either fall back to the older version or try again later.'); 'To resolve this issue you may either fall back to the older version or try again later.');
} }
else { else {
// For any other error type, you can log the error message.
core.setFailed(`An unexpected error occurred like url might not correct`); core.setFailed(`An unexpected error occurred like url might not correct`);
} }
throw error; throw error;

9
src/distributions/official_builds/official_builds.ts
View file

@ -16,15 +16,11 @@ export default class OfficialBuilds extends BaseDistribution {
public async setupNodeJs() { public async setupNodeJs() {
if (this.nodeInfo.mirrorURL) { if (this.nodeInfo.mirrorURL) {
let downloadPath = '';
try { try {
core.info(`Attempting to download using mirror URL...`); core.info(`Attempting to download using mirror URL...`);
downloadPath = await this.downloadFromMirrorURL(); // Attempt to download from the mirror await this.downloadFromMirrorURL(); // Attempt to download from the mirror
} catch (err) { } catch (err) {
core.setFailed((err as Error).message); core.setFailed((err as Error).message);
core.setFailed('Download failed');
core.debug((err as Error).stack ?? 'empty stack');
} }
} else { } else {
core.info('Setup Node.js'); core.info('Setup Node.js');
@ -331,11 +327,10 @@ export default class OfficialBuilds extends BaseDistribution {
if (error instanceof tc.HTTPError && error.httpStatusCode === 404) { if (error instanceof tc.HTTPError && error.httpStatusCode === 404) {
core.setFailed( core.setFailed(
`Node version ${this.nodeInfo.versionSpec} for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} was found but failed to download. ` + `Node version ${this.nodeInfo.versionSpec} for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} was found but failed to download. ` +
'This usually happens when downloadable binaries are not fully updated at https://nodejs.org/. ' + 'This usually happens when downloadable binaries are not fully updated in the provided mirror-url' +
'To resolve this issue you may either fall back to the older version or try again later.' 'To resolve this issue you may either fall back to the older version or try again later.'
); );
} else { } else {
// For any other error type, you can log the error message.
core.setFailed( core.setFailed(
`An unexpected error occurred like url might not correct` `An unexpected error occurred like url might not correct`
); );