From eff380dfbcf941bf8832e4acb788cebe13dfd758 Mon Sep 17 00:00:00 2001 From: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com> Date: Wed, 22 May 2024 08:12:24 -0500 Subject: [PATCH] Fix macos latest check failures (#1041) * Update latest node versions * Update latest node versions * Update test data * Update test data * Update test data * Update test data * Update test data * macos lts failure fix * Update macos-13 --- .github/workflows/e2e-cache.yml | 16 ++++++++-------- .github/workflows/versions.yml | 28 ++++++++++++++-------------- __tests__/data/.nvmrc | 2 +- __tests__/data/.tool-versions | 2 +- __tests__/data/.tool-versions-node | 2 +- __tests__/data/package-volta.json | 2 +- __tests__/data/package.json | 2 +- 7 files changed, 27 insertions(+), 27 deletions(-) diff --git a/.github/workflows/e2e-cache.yml b/.github/workflows/e2e-cache.yml index a0f20639..f9d3aaf2 100644 --- a/.github/workflows/e2e-cache.yml +++ b/.github/workflows/e2e-cache.yml @@ -19,7 +19,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [12, 14, 16] + node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 - name: Clean global cache @@ -42,7 +42,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [12, 14, 16] + node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 - name: Install pnpm @@ -75,7 +75,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [14, 16] + node-version: [18, 20] steps: - uses: actions/checkout@v4 - name: Yarn version @@ -107,7 +107,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [12, 14, 16] + node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 - name: Update yarn @@ -139,7 +139,7 @@ jobs: name: Test yarn subprojects strategy: matrix: - node-version: [12, 14, 16] + node-version: [18, 20, 22] runs-on: ubuntu-latest steps: @@ -166,7 +166,7 @@ jobs: name: Test yarn subprojects all locally managed strategy: matrix: - node-version: [12, 14, 16] + node-version: [18, 20, 22] runs-on: ubuntu-latest steps: @@ -193,7 +193,7 @@ jobs: name: Test yarn subprojects some locally managed strategy: matrix: - node-version: [12, 14, 16] + node-version: [18, 20, 22] runs-on: ubuntu-latest steps: @@ -220,7 +220,7 @@ jobs: name: Test yarn subprojects managed by git strategy: matrix: - node-version: [12, 14, 16] + node-version: [18, 20, 22] runs-on: ubuntu-latest steps: diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index acc500fc..8078deac 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -18,7 +18,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [10, 12, 14] + node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 - name: Setup Node @@ -34,7 +34,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-latest, windows-latest, macos-13] node-version: [lts/dubnium, lts/erbium, lts/fermium, lts/*, lts/-1] steps: - uses: actions/checkout@v4 @@ -43,7 +43,7 @@ jobs: with: node-version: ${{ matrix.node-version }} check-latest: true - - if: runner.os != 'Windows' + - if: runner.os != 'Windows' && runner.os != 'macOS' name: Verify node and npm run: | . "$NVM_DIR/nvm.sh" @@ -83,7 +83,7 @@ jobs: matrix: os: [ubuntu-latest, windows-latest, macos-latest] node-version: - [16.0.0-nightly20210420a0261d231c, 17-nightly, 18.0.0-nightly] + [20.11.0-nightly202312211a0be537da, 21-nightly, 18.0.0-nightly] steps: - uses: actions/checkout@v4 - name: Setup Node @@ -103,7 +103,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [16.0.0-rc.1, 18.0.0-rc.2, 19.0.0-rc.0] + node-version: [20.0.0-rc.1, 18.0.0-rc.2, 19.0.0-rc.0] steps: - uses: actions/checkout@v4 - name: Setup Node @@ -123,7 +123,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [10.15, 12.16.0, 14.2.0, 16.3.0] + node-version: [18.20.0, 20.10.0, 22.0.0] steps: - uses: actions/checkout@v4 - name: Setup Node @@ -140,7 +140,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [10, 12, 14] + node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 - name: Setup Node and check latest @@ -167,7 +167,7 @@ jobs: with: node-version-file: '__tests__/data/${{ matrix.node-version-file }}' - name: Verify node - run: __tests__/verify-node.sh 14 + run: __tests__/verify-node.sh 20 version-file-volta: runs-on: ${{ matrix.os }} @@ -182,7 +182,7 @@ jobs: with: node-version-file: '__tests__/data/package-volta.json' - name: Verify node - run: __tests__/verify-node.sh 16 + run: __tests__/verify-node.sh 20 version-file-volta-extends: runs-on: ${{ matrix.os }} @@ -197,7 +197,7 @@ jobs: with: node-version-file: '__tests__/data/package-volta-extends.json' - name: Verify node - run: __tests__/verify-node.sh 16 + run: __tests__/verify-node.sh 20 node-dist: runs-on: ${{ matrix.os }} @@ -205,7 +205,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [11, 13] + node-version: [17, 19] steps: - uses: actions/checkout@v4 - name: Setup Node from dist @@ -221,7 +221,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-latest, windows-latest, macos-13] steps: - uses: actions/checkout@v4 # test old versions which didn't have npm and layout different @@ -237,10 +237,10 @@ jobs: runs-on: windows-latest steps: - uses: actions/checkout@v4 - - name: Setup node 14 x86 from dist + - name: Setup node 20 x86 from dist uses: ./ with: - node-version: '14' + node-version: '20' architecture: 'x86' - name: Verify node run: __tests__/verify-arch.sh "ia32" diff --git a/__tests__/data/.nvmrc b/__tests__/data/.nvmrc index ca3f1e5c..9a2a0e21 100644 --- a/__tests__/data/.nvmrc +++ b/__tests__/data/.nvmrc @@ -1 +1 @@ -v14 \ No newline at end of file +v20 diff --git a/__tests__/data/.tool-versions b/__tests__/data/.tool-versions index 317343f3..6de89a83 100644 --- a/__tests__/data/.tool-versions +++ b/__tests__/data/.tool-versions @@ -1 +1 @@ -nodejs 14.0.0 +nodejs 20.0.0 diff --git a/__tests__/data/.tool-versions-node b/__tests__/data/.tool-versions-node index 8e8ac418..4d5dd711 100644 --- a/__tests__/data/.tool-versions-node +++ b/__tests__/data/.tool-versions-node @@ -1 +1 @@ -node 14.0.0 +node 20.0.0 diff --git a/__tests__/data/package-volta.json b/__tests__/data/package-volta.json index ebee7dfc..6c9583f1 100644 --- a/__tests__/data/package-volta.json +++ b/__tests__/data/package-volta.json @@ -3,6 +3,6 @@ "node": "^14.0.0" }, "volta": { - "node": "16.0.0" + "node": "20.0.0" } } diff --git a/__tests__/data/package.json b/__tests__/data/package.json index b201009d..4fb385a2 100644 --- a/__tests__/data/package.json +++ b/__tests__/data/package.json @@ -1,5 +1,5 @@ { "engines": { - "node": "^14.0.0" + "node": "^20.0.0" } }