actions/setup-node
1
0
Fork 0
mirror of https://github.com/actions/setup-node synced 2024-12-22 21:22:42 +00:00
Code Issues Activity

Force all scope names to be lowercased (#39)

Browse source 
Fixes #38
This commit is contained in:
James M. Greene 2019-08-21 21:46:35 -05:00 committed by Danny McCormick
parent 3d792c1dbd
commit d43864199a
4 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
__tests__/__snapshots__/authutil.test.ts.snap
View file

@ -7,12 +7,12 @@ registry=https://registry.npmjs.org/"
exports[`installer tests Automatically configures GPR scope 1`] = ` exports[`installer tests Automatically configures GPR scope 1`] = `
"npm.pkg.github.com/:_authToken=\${NODE_AUTH_TOKEN} "npm.pkg.github.com/:_authToken=\${NODE_AUTH_TOKEN}
@owner:registry=npm.pkg.github.com/" @ownername:registry=npm.pkg.github.com/"
`; `;
exports[`installer tests Configures scoped npm registries 1`] = ` exports[`installer tests Configures scoped npm registries 1`] = `
"//registry.npmjs.org/:_authToken=\${NODE_AUTH_TOKEN} "//registry.npmjs.org/:_authToken=\${NODE_AUTH_TOKEN}
@myScope:registry=https://registry.npmjs.org/" @myscope:registry=https://registry.npmjs.org/"
`; `;
exports[`installer tests Sets up npmrc for npmjs 1`] = ` exports[`installer tests Sets up npmrc for npmjs 1`] = `

2
__tests__/authutil.test.ts
View file

@ -15,7 +15,7 @@ const tempDir = path.join(
const rcFile = path.join(tempDir, '.npmrc'); const rcFile = path.join(tempDir, '.npmrc');
process.env['GITHUB_REPOSITORY'] = 'owner/repo'; process.env['GITHUB_REPOSITORY'] = 'OwnerName/repo';
process.env['RUNNER_TEMP'] = tempDir; process.env['RUNNER_TEMP'] = tempDir;
import * as auth from '../src/authutil'; import * as auth from '../src/authutil';

3
lib/authutil.js
View file

@ -28,6 +28,9 @@ function writeRegistryToFile(registryUrl, fileLocation) {
if (scope && scope[0] != '@') { if (scope && scope[0] != '@') {
scope = '@' + scope; scope = '@' + scope;
} }
if (scope) {
scope = scope.toLowerCase();
}
core.debug(`Setting auth in ${fileLocation}`); core.debug(`Setting auth in ${fileLocation}`);
let newContents = ''; let newContents = '';
if (fs.existsSync(fileLocation)) { if (fs.existsSync(fileLocation)) {

3
src/authutil.ts
View file

@ -24,6 +24,9 @@ function writeRegistryToFile(registryUrl: string, fileLocation: string) {
if (scope && scope[0] != '@') { if (scope && scope[0] != '@') {
scope = '@' + scope; scope = '@' + scope;
} }
if (scope) {
scope = scope.toLowerCase();
}
core.debug(`Setting auth in ${fileLocation}`); core.debug(`Setting auth in ${fileLocation}`);
let newContents: string = ''; let newContents: string = '';