actions/setup-node
1
0
Fork 0
mirror of https://github.com/actions/setup-node synced 2025-04-09 18:35:51 +00:00
Code Issues Activity

review fixes

Browse source
This commit is contained in:
Sergey Dolin 2023-06-02 18:50:25 +02:00
parent 9ddc512bc1
commit d2b7e08b80
3 changed files with 15 additions and 23 deletions
dist
cache-save
index.js
setup
index.js
src
cache-utils.ts

11
dist/cache-save/index.js vendored
View file

@ -60522,15 +60522,14 @@ const getProjectDirectoriesFromCacheDependencyPath = (cacheDependencyPath) => __
cacheDependenciesPaths = memoized;
}
else {
cacheDependenciesPaths = (yield glob
.create(cacheDependencyPath)
.then(globber => globber.glob())) || [''];
const globber = yield glob.create(cacheDependencyPath);
cacheDependenciesPaths = (yield globber.glob()) || [''];
exports.memoizedCacheDependencies[cacheDependencyPath] = cacheDependenciesPaths;
}
const existingDirectories = cacheDependenciesPaths
.map(cacheDependencyPath => path_1.default.dirname(cacheDependencyPath))
.map(path_1.default.dirname)
// uniq in order to do not traverse the same directories during the further processing
.filter((cachePath, i, result) => cachePath != null && result.indexOf(cachePath) === i)
.filter((item, i, src) => item != null && src.indexOf(item) === i)
.filter(directory => fs_1.default.existsSync(directory) && fs_1.default.lstatSync(directory).isDirectory());
// if user explicitly pointed out some file, but it does not exist it is definitely
// not he wanted, thus we should throw an error not trying to workaround with unexpected
@ -60555,7 +60554,7 @@ const getCacheDirectoriesFromCacheDependencyPath = (packageManagerInfo, cacheDep
return cacheFolderPath;
})));
// uniq in order to do not cache the same directories twice
return cacheFoldersPaths.filter((cachePath, i, result) => result.indexOf(cachePath) === i);
return cacheFoldersPaths.filter((item, i, src) => src.indexOf(item) === i);
});
/**
* Finds the cache directories configured for the repo ignoring cache-dependency-path

11
dist/setup/index.js vendored
View file

@ -71304,15 +71304,14 @@ const getProjectDirectoriesFromCacheDependencyPath = (cacheDependencyPath) => __
cacheDependenciesPaths = memoized;
}
else {
cacheDependenciesPaths = (yield glob
.create(cacheDependencyPath)
.then(globber => globber.glob())) || [''];
const globber = yield glob.create(cacheDependencyPath);
cacheDependenciesPaths = (yield globber.glob()) || [''];
exports.memoizedCacheDependencies[cacheDependencyPath] = cacheDependenciesPaths;
}
const existingDirectories = cacheDependenciesPaths
.map(cacheDependencyPath => path_1.default.dirname(cacheDependencyPath))
.map(path_1.default.dirname)
// uniq in order to do not traverse the same directories during the further processing
.filter((cachePath, i, result) => cachePath != null && result.indexOf(cachePath) === i)
.filter((item, i, src) => item != null && src.indexOf(item) === i)
.filter(directory => fs_1.default.existsSync(directory) && fs_1.default.lstatSync(directory).isDirectory());
// if user explicitly pointed out some file, but it does not exist it is definitely
// not he wanted, thus we should throw an error not trying to workaround with unexpected
@ -71337,7 +71336,7 @@ const getCacheDirectoriesFromCacheDependencyPath = (packageManagerInfo, cacheDep
return cacheFolderPath;
})));
// uniq in order to do not cache the same directories twice
return cacheFoldersPaths.filter((cachePath, i, result) => result.indexOf(cachePath) === i);
return cacheFoldersPaths.filter((item, i, src) => src.indexOf(item) === i);
});
/**
* Finds the cache directories configured for the repo ignoring cache-dependency-path

16
src/cache-utils.ts
View file

@ -131,19 +131,15 @@ const getProjectDirectoriesFromCacheDependencyPath = async (
if (memoized) {
cacheDependenciesPaths = memoized;
} else {
cacheDependenciesPaths = (await glob
.create(cacheDependencyPath)
.then(globber => globber.glob())) || [''];
const globber = await glob.create(cacheDependencyPath);
cacheDependenciesPaths = (await globber.glob()) || [''];
memoizedCacheDependencies[cacheDependencyPath] = cacheDependenciesPaths;
}
const existingDirectories: string[] = cacheDependenciesPaths
.map(cacheDependencyPath => path.dirname(cacheDependencyPath))
.map(path.dirname)
// uniq in order to do not traverse the same directories during the further processing
.filter(
(cachePath, i, result) =>
cachePath != null && result.indexOf(cachePath) === i
)
.filter((item, i, src) => item != null && src.indexOf(item) === i)
.filter(
directory =>
fs.existsSync(directory) && fs.lstatSync(directory).isDirectory()
@ -187,9 +183,7 @@ const getCacheDirectoriesFromCacheDependencyPath = async (
)
);
// uniq in order to do not cache the same directories twice
return cacheFoldersPaths.filter(
(cachePath, i, result) => result.indexOf(cachePath) === i
);
return cacheFoldersPaths.filter((item, i, src) => src.indexOf(item) === i);
};
/**