actions/setup-node
1
0
Fork 0
mirror of https://github.com/actions/setup-node synced 2024-12-22 13:12:43 +00:00
Code Issues Activity

Use early return pattern

Browse source
This commit is contained in:
Sergey Dolin 2022-12-09 11:41:54 +01:00
parent d1b197b965
commit 676975d9aa
3 changed files with 22 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
dist/cache-save/index.js vendored
View file

@ -61185,16 +61185,12 @@ function isGhes() {
} }
exports.isGhes = isGhes; exports.isGhes = isGhes;
function isCacheFeatureAvailable() { function isCacheFeatureAvailable() {
if (!cache.isFeatureAvailable()) { if (cache.isFeatureAvailable())
if (isGhes()) { return true;
throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.'); if (isGhes())
} throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.');
else { core.warning('The runner was not able to contact the cache service. Caching will be skipped');
core.warning('The runner was not able to contact the cache service. Caching will be skipped'); return false;
}
return false;
}
return true;
} }
exports.isCacheFeatureAvailable = isCacheFeatureAvailable; exports.isCacheFeatureAvailable = isCacheFeatureAvailable;

16
dist/setup/index.js vendored
View file

@ -73139,16 +73139,12 @@ function isGhes() {
} }
exports.isGhes = isGhes; exports.isGhes = isGhes;
function isCacheFeatureAvailable() { function isCacheFeatureAvailable() {
if (!cache.isFeatureAvailable()) { if (cache.isFeatureAvailable())
if (isGhes()) { return true;
throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.'); if (isGhes())
} throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.');
else { core.warning('The runner was not able to contact the cache service. Caching will be skipped');
core.warning('The runner was not able to contact the cache service. Caching will be skipped'); return false;
}
return false;
}
return true;
} }
exports.isCacheFeatureAvailable = isCacheFeatureAvailable; exports.isCacheFeatureAvailable = isCacheFeatureAvailable;

23
src/cache-utils.ts
View file

@ -105,19 +105,16 @@ export function isGhes(): boolean {
} }
export function isCacheFeatureAvailable(): boolean { export function isCacheFeatureAvailable(): boolean {
if (!cache.isFeatureAvailable()) { if (cache.isFeatureAvailable()) return true;
if (isGhes()) {
throw new Error(
'Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.'
);
} else {
core.warning(
'The runner was not able to contact the cache service. Caching will be skipped'
);
}
return false; if (isGhes())
} throw new Error(
'Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.'
);
return true; core.warning(
'The runner was not able to contact the cache service. Caching will be skipped'
);
return false;
} }