mirror of
https://github.com/actions/setup-node
synced 2024-12-23 05:34:56 +00:00
fix: add warning for when arch is supplied but version is missing
This commit is contained in:
parent
2801f51f90
commit
2a5c060ce2
2 changed files with 14 additions and 0 deletions
5
dist/index.js
vendored
5
dist/index.js
vendored
|
@ -4645,6 +4645,11 @@ function run() {
|
||||||
version = core.getInput('version');
|
version = core.getInput('version');
|
||||||
}
|
}
|
||||||
let arch = core.getInput('node-arch');
|
let arch = core.getInput('node-arch');
|
||||||
|
// if node-arch supplied but node-version is not
|
||||||
|
// if we don't throw a warning, the already installed x64 node will be used which is not probably what user meant.
|
||||||
|
if (arch && !version) {
|
||||||
|
core.warning('`node-arch` is provided but `node-version` is missing. This results in using an already installed x64 node which is not probably what you meant. To fix this, provide `node-arch` in combination with `node-version`');
|
||||||
|
}
|
||||||
if (!arch) {
|
if (!arch) {
|
||||||
arch = os.arch();
|
arch = os.arch();
|
||||||
}
|
}
|
||||||
|
|
|
@ -17,6 +17,15 @@ export async function run() {
|
||||||
}
|
}
|
||||||
|
|
||||||
let arch = core.getInput('node-arch');
|
let arch = core.getInput('node-arch');
|
||||||
|
|
||||||
|
// if node-arch supplied but node-version is not
|
||||||
|
// if we don't throw a warning, the already installed x64 node will be used which is not probably what user meant.
|
||||||
|
if (arch && !version) {
|
||||||
|
core.warning(
|
||||||
|
'`node-arch` is provided but `node-version` is missing. This results in using an already installed x64 node which is not probably what you meant. To fix this, provide `node-arch` in combination with `node-version`'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
if (!arch) {
|
if (!arch) {
|
||||||
arch = os.arch();
|
arch = os.arch();
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue