From 807559307d542a5495f464a56759b0b2a7fdcf79 Mon Sep 17 00:00:00 2001 From: Serghei Iakovlev Date: Tue, 31 Jan 2023 11:46:49 +0100 Subject: [PATCH] Use const declarations for variables that are never reassigned (#322) --- README.md | 2 +- dist/setup/index.js | 14 +++++++------- src/installer.ts | 12 ++++++------ src/main.ts | 4 ++-- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 1346158..d551d2c 100644 --- a/README.md +++ b/README.md @@ -155,7 +155,7 @@ steps: ``` ## Getting go version from the go.mod file -The `go-version-file` input accepts a path to a `go.mod` file or a `go.work` file that contains the version of Go to be used by a project. As the `go.mod` file contains only major and minor (e.g. 1.18) tags, the action will search for the latest available patch version sequentially in the runner's directory with the cached tools, in the [version-manifest.json](https://github.com/actions/go-versions/blob/main/versions-manifest.json) file or at the go servers. +The `go-version-file` input accepts a path to a `go.mod` file or a `go.work` file that contains the version of Go to be used by a project. As the `go.mod` file contains only major and minor (e.g. 1.18) tags, the action will search for the latest available patch version sequentially in the runner's directory with the cached tools, in the [versions-manifest.json](https://github.com/actions/go-versions/blob/main/versions-manifest.json) file or at the go servers. If both the `go-version` and the `go-version-file` inputs are provided then the `go-version` input is used. > The action will search for the `go.mod` file relative to the repository root diff --git a/dist/setup/index.js b/dist/setup/index.js index cbc2a3c..38e8143 100644 --- a/dist/setup/index.js +++ b/dist/setup/index.js @@ -63398,12 +63398,12 @@ function getInfoFromDist(versionSpec, arch) { } function findMatch(versionSpec, arch = os_1.default.arch()) { return __awaiter(this, void 0, void 0, function* () { - let archFilter = sys.getArch(arch); - let platFilter = sys.getPlatform(); + const archFilter = sys.getArch(arch); + const platFilter = sys.getPlatform(); let result; let match; const dlUrl = 'https://golang.org/dl/?mode=json&include=all'; - let candidates = yield module.exports.getVersionsDist(dlUrl); + const candidates = yield module.exports.getVersionsDist(dlUrl); if (!candidates) { throw new Error(`golang download url did not return results`); } @@ -63436,7 +63436,7 @@ exports.findMatch = findMatch; function getVersionsDist(dlUrl) { return __awaiter(this, void 0, void 0, function* () { // this returns versions descending so latest is first - let http = new httpm.HttpClient('setup-go', [], { + const http = new httpm.HttpClient('setup-go', [], { allowRedirects: true, maxRedirects: 3 }); @@ -63484,7 +63484,7 @@ function resolveStableVersionDist(versionSpec, arch) { let archFilter = sys.getArch(arch); let platFilter = sys.getPlatform(); const dlUrl = 'https://golang.org/dl/?mode=json&include=all'; - let candidates = yield module.exports.getVersionsDist(dlUrl); + const candidates = yield module.exports.getVersionsDist(dlUrl); if (!candidates) { throw new Error(`golang download url did not return results`); } @@ -63611,8 +63611,8 @@ function run() { const matchersPath = path_1.default.join(__dirname, '../..', 'matchers.json'); core.info(`##[add-matcher]${matchersPath}`); // output the version actually being used - let goPath = yield io.which('go'); - let goVersion = (child_process_1.default.execSync(`${goPath} version`) || '').toString(); + const goPath = yield io.which('go'); + const goVersion = (child_process_1.default.execSync(`${goPath} version`) || '').toString(); core.info(goVersion); core.setOutput('go-version', parseGoVersion(goVersion)); core.startGroup('go env'); diff --git a/src/installer.ts b/src/installer.ts index 7074f5e..dfd734b 100644 --- a/src/installer.ts +++ b/src/installer.ts @@ -266,14 +266,14 @@ export async function findMatch( versionSpec: string, arch = os.arch() ): Promise { - let archFilter = sys.getArch(arch); - let platFilter = sys.getPlatform(); + const archFilter = sys.getArch(arch); + const platFilter = sys.getPlatform(); let result: IGoVersion | undefined; let match: IGoVersion | undefined; - const dlUrl: string = 'https://golang.org/dl/?mode=json&include=all'; - let candidates: IGoVersion[] | null = await module.exports.getVersionsDist( + const dlUrl = 'https://golang.org/dl/?mode=json&include=all'; + const candidates: IGoVersion[] | null = await module.exports.getVersionsDist( dlUrl ); if (!candidates) { @@ -315,7 +315,7 @@ export async function getVersionsDist( dlUrl: string ): Promise { // this returns versions descending so latest is first - let http: httpm.HttpClient = new httpm.HttpClient('setup-go', [], { + const http: httpm.HttpClient = new httpm.HttpClient('setup-go', [], { allowRedirects: true, maxRedirects: 3 }); @@ -372,7 +372,7 @@ async function resolveStableVersionDist(versionSpec: string, arch: string) { let archFilter = sys.getArch(arch); let platFilter = sys.getPlatform(); const dlUrl: string = 'https://golang.org/dl/?mode=json&include=all'; - let candidates: IGoVersion[] | null = await module.exports.getVersionsDist( + const candidates: IGoVersion[] | null = await module.exports.getVersionsDist( dlUrl ); if (!candidates) { diff --git a/src/main.ts b/src/main.ts index 5833f16..6558753 100644 --- a/src/main.ts +++ b/src/main.ts @@ -67,8 +67,8 @@ export async function run() { core.info(`##[add-matcher]${matchersPath}`); // output the version actually being used - let goPath = await io.which('go'); - let goVersion = (cp.execSync(`${goPath} version`) || '').toString(); + const goPath = await io.which('go'); + const goVersion = (cp.execSync(`${goPath} version`) || '').toString(); core.info(goVersion); core.setOutput('go-version', parseGoVersion(goVersion));