1
0
Fork 0
mirror of https://github.com/actions/go-versions synced 2024-11-21 19:52:39 +00:00

resolved comments

This commit is contained in:
Nikita Bykov 2020-08-26 15:58:05 +03:00
parent c455148af9
commit e33ef4429e
2 changed files with 3 additions and 7 deletions

View file

@ -33,7 +33,6 @@ jobs:
submodules: true submodules: true
- name: Build Go ${{ env.VERSION }} - name: Build Go ${{ env.VERSION }}
shell: pwsh
run: | run: |
./builders/build-go.ps1 -Version $env:VERSION ` ./builders/build-go.ps1 -Version $env:VERSION `
-Platform ${{ matrix.platform }} -Platform ${{ matrix.platform }}
@ -100,7 +99,6 @@ jobs:
Write-Host "We need it because log of previous step 'Setup Go' is not available here yet." Write-Host "We need it because log of previous step 'Setup Go' is not available here yet."
Write-Host "In testing step (Go.Tests.ps1) we analyze build log of 'Setup Go' task" Write-Host "In testing step (Go.Tests.ps1) we analyze build log of 'Setup Go' task"
Write-Host "to determine if Go.js version was consumed from cache and was downloaded" Write-Host "to determine if Go.js version was consumed from cache and was downloaded"
Write-Host "Random values:"
for ($i = 0; $i -lt 200; $i++) { Get-Random } for ($i = 0; $i -lt 200; $i++) { Get-Random }
- name: Run tests - name: Run tests
@ -115,8 +113,6 @@ jobs:
if: github.event.inputs.PUBLISH_RELEASES == 'true' if: github.event.inputs.PUBLISH_RELEASES == 'true'
needs: test_go needs: test_go
runs-on: ubuntu-latest runs-on: ubuntu-latest
outputs:
upload_url: ${{ steps.create_release.outputs.upload_url }}
steps: steps:
- uses: actions/download-artifact@v2 - uses: actions/download-artifact@v2
@ -129,7 +125,7 @@ jobs:
tag_name: ${{ env.VERSION }}-${{ github.run_id }} tag_name: ${{ env.VERSION }}-${{ github.run_id }}
release_name: ${{ env.VERSION }} release_name: ${{ env.VERSION }}
body: | body: |
Upload Go ${{ env.VERSION }} Go ${{ env.VERSION }}
- name: Upload release assets - name: Upload release assets
uses: actions/github-script@v2 uses: actions/github-script@v2
@ -155,7 +151,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Trigger "Create Pull Request" workflow - name: Trigger "Create Pull Request" workflow
uses: actions/github-script@v2 uses: actions/github-script@v3
with: with:
github-token: ${{ secrets.PERSONAL_TOKEN }} github-token: ${{ secrets.PERSONAL_TOKEN }}
script: | script: |

View file

@ -4,6 +4,7 @@ Import-Module (Join-Path $PSScriptRoot "../helpers/common-helpers.psm1")
BeforeAll { BeforeAll {
Set-Location -Path "source" Set-Location -Path "source"
$sourceLocation = Get-Location $sourceLocation = Get-Location
function Get-UseGoLogs { function Get-UseGoLogs {
# GitHub Windows images don't have `HOME` variable # GitHub Windows images don't have `HOME` variable
$homeDir = $env:HOME ?? $env:HOMEDRIVE $homeDir = $env:HOME ?? $env:HOMEDRIVE
@ -17,7 +18,6 @@ BeforeAll {
} }
} }
Describe "Go" { Describe "Go" {
It "is available" { It "is available" {
"go version" | Should -ReturnZeroExitCode "go version" | Should -ReturnZeroExitCode